build: track weechat header inputs - #47
Merged
Merged
Conversation
Komzpa
marked this pull request as ready for review
June 23, 2026 18:02
strk
approved these changes
Jun 24, 2026
strk
left a comment
strk
left a comment
Collaborator
There was a problem hiding this comment.
Easy to review for someone who knows Rust (not me).
I trust the author of the patch so approving FWIW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bindgen now tells Cargo which WeeChat headers it read while generating
weechat-sysbindings.That means changing
WEECHAT_PLUGIN_FILEwas already tracked, and now changing the selected header contents is tracked too. Downstream builds should not needmake cleanjust to pick up header changes.Checked with
cargo fmt --check,cargo check -p weechat-sys, and atouch crates/weechat-sys/src/wrapper.hsmoke that made Cargo reportDirty weechat-sys.Fix requested by @strk.