Render "Find out why?" in test mode banner - #14301
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Confidence score: 4/5
clients/apps/web/src/components/Checkout/Checkout.tsxcan show “Find out why?” to members withoutorganization:manage, even though the linked finance account route rejects them; gate the link on the organization’sorganization:managepermission to avoid a broken user flow.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="clients/apps/web/src/components/Checkout/Checkout.tsx">
<violation number="1" location="clients/apps/web/src/components/Checkout/Checkout.tsx:78">
P2: When a member lacks `organization:manage`, this condition still renders “Find out why?”, but the linked finance account route rejects that member. Gate the link on the organization’s `organization:manage` permission instead of membership alone.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| <p> | ||
| You can test checkout with free products or 100% discount orders. | ||
| </p> | ||
| {isOrganizationMember && ( |
Contributor
There was a problem hiding this comment.
P2: When a member lacks organization:manage, this condition still renders “Find out why?”, but the linked finance account route rejects that member. Gate the link on the organization’s organization:manage permission instead of membership alone.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At clients/apps/web/src/components/Checkout/Checkout.tsx, line 78:
<comment>When a member lacks `organization:manage`, this condition still renders “Find out why?”, but the linked finance account route rejects that member. Gate the link on the organization’s `organization:manage` permission instead of membership alone.</comment>
<file context>
@@ -61,9 +70,25 @@ const PaymentNotReadyBanner = ({
+ <p>
+ You can test checkout with free products or 100% discount orders.
+ </p>
+ {isOrganizationMember && (
+ <p>
+ <Link
</file context>
sebastianekstrom
approved these changes
Sep 21, 2026
Co-authored-by: Sebastian Ekström <seb.ekstrom@gmail.com>
Contributor
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.
Re-trigger cubic
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.