Skip to content

Render "Find out why?" in test mode banner - #14301

Merged
pieterbeulque merged 2 commits into
mainfrom
pieter/test-mode-link
Sep 21, 2026
Merged

pieterbeulque merged 2 commits into
mainfrom
pieter/test-mode-link

Conversation

@pieterbeulque

@pieterbeulque pieterbeulque commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Review in cubic

@vercel

vercel Bot commented Sep 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
orbit Ready Ready Preview Sep 21, 2026 2:43pm UTC
polar-test Ready Ready Preview Sep 21, 2026 2:43pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Confidence score: 4/5

  • clients/apps/web/src/components/Checkout/Checkout.tsx can show “Find out why?” to members without organization:manage, even though the linked finance account route rejects them; gate the link on the organization’s organization:manage permission to avoid a broken user flow.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="clients/apps/web/src/components/Checkout/Checkout.tsx">

<violation number="1" location="clients/apps/web/src/components/Checkout/Checkout.tsx:78">
P2: When a member lacks `organization:manage`, this condition still renders “Find out why?”, but the linked finance account route rejects that member. Gate the link on the organization’s `organization:manage` permission instead of membership alone.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

<p>
You can test checkout with free products or 100% discount orders.
</p>
{isOrganizationMember && (

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: When a member lacks organization:manage, this condition still renders “Find out why?”, but the linked finance account route rejects that member. Gate the link on the organization’s organization:manage permission instead of membership alone.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At clients/apps/web/src/components/Checkout/Checkout.tsx, line 78:

<comment>When a member lacks `organization:manage`, this condition still renders “Find out why?”, but the linked finance account route rejects that member. Gate the link on the organization’s `organization:manage` permission instead of membership alone.</comment>

<file context>
@@ -61,9 +70,25 @@ const PaymentNotReadyBanner = ({
+            <p>
+              You can test checkout with free products or 100% discount orders.
+            </p>
+            {isOrganizationMember && (
+              <p>
+                <Link
</file context>

Comment thread clients/apps/web/src/components/Checkout/Checkout.tsx Outdated
Co-authored-by: Sebastian Ekström <seb.ekstrom@gmail.com>
@pieterbeulque
pieterbeulque added this pull request to the merge queue Sep 21, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.

Re-trigger cubic

Merged via the queue into main with commit 7ccfa8e Sep 21, 2026
25 checks passed
@pieterbeulque
pieterbeulque deleted the pieter/test-mode-link branch September 21, 2026 14:45

This branch was successfully deployed

2 active deployments
Preview – polar-test b4c8ee4c Deployed Sep 21, 2026 by vercel[bot]
Preview – orbit b4c8ee4c Deployed Sep 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants