Skip to content

Adds sample data in EPT format#17

Open
iosefa wants to merge 2 commits into
pnext:masterfrom
iosefa:master
Open

Adds sample data in EPT format#17
iosefa wants to merge 2 commits into
pnext:masterfrom
iosefa:master

Conversation

@iosefa

@iosefa iosefa commented Aug 4, 2018

Copy link
Copy Markdown

This PR adds sample data in the EPT format.

The sample dataset was originally prepared by Markus Neteler and Helena Mitasova in their book "Open Source GIS: A GRASS GIS Approach". It has been converted to the EPT format for testing purposes.

@dkastl

dkastl commented Aug 6, 2018

Copy link
Copy Markdown
Contributor

@iosefa , is this NorthCarolina data from GRASS workshop?

@iosefa

iosefa commented Aug 6, 2018

Copy link
Copy Markdown
Author

@dkastl , yes it is

@dkastl dkastl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we don't change this data too often, it should not increase the size of the repository too

@martinheidegger

martinheidegger commented Aug 7, 2018

Copy link
Copy Markdown
Contributor

Thank you for the PR ... oh so many files 😅 . After reading your kind documentation

The following dataset may be used for visualization and testing purposes.

... I was wondering if we should place the data in a own repository (That is published on npm). In order for the data to be only downloaded for development purposes and not keep historic data. Would you be okay with that? @pnext/admin

The data itself is looks good with lots of edges that allow for good tests. What i noticed: I wish there also was binary data version to test the other way data could be stored (also its quicker to implement).

@martinheidegger

Copy link
Copy Markdown
Contributor

Ping @iosefa

@iosefa

iosefa commented Aug 17, 2018

Copy link
Copy Markdown
Author

@martinheidegger, Aren't .las and .laz binary file formats? Or was there another specific file format that you were thinking of? Re. a published repository on npm, I can get to this next week 😄

@martinheidegger

Copy link
Copy Markdown
Contributor

Yes, .las and .laz are binary file formats; but EPT supports custom binary data: https://github.com/connormanning/ept#datatype

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants