docs(AGENTS): add smoke-tests subtree, trim SshCache 0.15.0 duplication - #612
Merged
Conversation
Audit pass against current main. Architecture and Test-layout sections both had small accuracy drift since #609: - `tests/smoke/test_optional_deps.py` (PR #609) is not mentioned; add a bullet under Test layout describing the `-m smoke` marker, the per-extra round-trip pattern, and its role as a pre-release sanity check on the packaged distribution. - `pyproject.toml` now carries `[tool.pytest.ini_options]` (registering the `smoke` marker — also from #609); the doc still claimed there was no such section. Reworded the pytest-config sentence. - Disambiguated `unit/storage/test_optional_deps.py` (the existing full-coverage per-backend file) from the new `smoke/test_optional_deps.py` so a reader doesn't conflate them. Trimmed three sites that all said "SshCache shipped in 0.15.0 via the `python -m fleche remote --serve` dispatcher (PR #597)": - `remote.py` row: dropped the `landed #551 / released 0.15.0` aside and the `PR #597 moved the CLI` parenthetical (the form is what matters for callers; the history is one line of git away). - "Distributed / remote caching" design-theme bullet: removed the repeated SshCache description so the bullet covers only what's still open (#552 cold-tier values). - "Decisions already landed" SshCache + CLI bullets: collapsed two bullets into one — the CLI dispatcher is part of the SshCache delivery story, no need to list it separately. Also alphabetised the `__all__` enumeration in the `remote.py` row to match the source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit pass of
AGENTS.mdagainst currentmain(3a34ea7). Architecture / Key-files / MRO / Storage-composition sections were all verified accurate against the source — the only material drift is in the Test-layout section after PR #609, plus a few sites that triple-list the SshCache 0.15.0 /python -m flechestory.What changed
Test layout
smoke/bullet coveringtests/smoke/test_optional_deps.py(PR Add fast smoke-test set touching each optional dependency #609): one tiny@fleche()round-trip per optional dep (cloudpickle/dill/sqlalchemy/bagofholding/attrs), asserting the second call is served from the backend so the dep is genuinely functional (not just importable). Selectable withpytest -m smoke; usespytest.importorskipso absent deps skip rather than fail.pyproject.tomldoes now have[tool.pytest.ini_options](registers thesmokemarker, also from Add fast smoke-test set touching each optional dependency #609). The doc still claimed there was no such section.unit/storage/test_optional_deps.py(existing full-coverage per-backend file) from the newsmoke/test_optional_deps.py— a reader scanning the file list shouldn't conflate them.Trim SshCache / CLI repetition
"SshCache shipped in 0.15.0 via
python -m fleche remote --serve(PR #597 CLI dispatcher)" was being told three times:remote.pyrow: dropped thelanded #551 / released 0.15.0aside and thePR #597 moved the CLI behind a dispatcherparenthetical. The form is what callers need; the archaeology is one line ofgit logaway.#552cold-tier values).SshCacheandCLI consolidatedbullets into one — the CLI dispatcher is part of the SshCache delivery story, no value in listing twice.Also alphabetised the
__all__enumeration in theremote.pyrow to match the source (["RemoteConnectionError", "SshCache", "serve"]).Verified (no changes needed)
fleche/__init__.pymatches the listed exports.digest._digest_bytes(int → Digest → str → None → Number → bytes → np.ndarray → np.bool_ → FunctionType → CodeType → datetime/timezone → staticmethod/classmethod/property → dataclass → attrs → ModuleType → Mapping → Iterable).Call/DigestedCall/LazyCallAPI includingLazyCall.detach(call.py:400),FunctionProfile.of,_get_profilewith the__wrapped__fallback,lru_cache(maxsize=1000).BaseCache.shrinkTemplate Method +_shrinkabstract (caches.py:96,131-132),_first_hit/_collect/_foreachonCacheStack(caches.py:610,640,671).storage/base.pyhierarchy (OperationContext(ABC)→KeyManagement→StorageBackend),Intent(StrEnum),_operation_context(key, *, intent=Intent.WRITE).ValueMemory,CallMemory,Value/CallPickleFile,Value/CallBagOfHoldingH5File,Sql,Value/CallVoid) matchescaches.py/memory.py/pickle_file.py/bagofholding_file.py/sql.py/void.py.digest._digest#333; PR remove isolate from fleche decorator #523 still open).Test plan
git diff --stat AGENTS.md→1 file changed, 7 insertions(+), 7 deletions(-).Generated by Claude Code