-
Notifications
You must be signed in to change notification settings - Fork 8
Support Babel 8 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
5
commits into
main
Choose a base branch
from
copilot/support-babel-8
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support Babel 8 #16
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
49d8701
Initial plan
Copilot 51422d1
feat: support Babel 8 by updating version assertion and dependency range
Copilot 2155b64
test: add Babel 7/8 version compatibility test suite
Copilot dc3543c
test: use real Babel 7 and 8 packages in test suite
Copilot cad2e21
refactor: alias @babel/core v7 as babel-core-7 in tests
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,77 +1,88 @@ | ||
| import * as babel from '@babel/core' | ||
| import { it, expect } from 'vitest' | ||
| import * as babel7 from 'babel-core-7' | ||
| import * as babel8 from 'babel-core-8' | ||
| import { it, expect, describe } from 'vitest' | ||
| import plugin from '../src/index' | ||
|
|
||
| function transform(code: string): string { | ||
| return babel.transform(code.replace(/\s+/g, ' '), { plugins: [plugin] })!.code! | ||
| function transformWith(babelCore: typeof babel7, code: string): string { | ||
| return babelCore.transformSync(code.replace(/\s+/g, ' '), { plugins: [plugin] })!.code! | ||
| } | ||
|
|
||
| it('removes namespaced extend calls', () => { | ||
| const code = transform( | ||
| ` | ||
| import * as THREE from "three"; | ||
| import { extend } from "@react-three/fiber"; | ||
| describe.each([ | ||
| { name: 'Babel 7', babel: babel7 }, | ||
| { name: 'Babel 8', babel: babel8 as unknown as typeof babel7 }, | ||
| ])('$name', ({ babel }) => { | ||
| it('removes namespaced extend calls', () => { | ||
| const code = transformWith( | ||
| babel, | ||
| ` | ||
| import * as THREE from "three"; | ||
| import { extend } from "@react-three/fiber"; | ||
|
|
||
| extend(THREE); | ||
| `, | ||
| ) | ||
| expect(code).toMatchSnapshot() | ||
| }) | ||
| extend(THREE); | ||
| `, | ||
| ) | ||
| expect(code).toMatchSnapshot() | ||
| }) | ||
|
|
||
| it('handles JSX', () => { | ||
| const code = transform( | ||
| ` | ||
| function Box(props) { | ||
| return ( | ||
| <mesh {...props}> | ||
| <boxGeometry /> | ||
| <meshBasicMaterial /> | ||
| </mesh> | ||
| ); | ||
| } | ||
| `, | ||
| ) | ||
| expect(code).toMatchSnapshot() | ||
| }) | ||
| it('handles JSX', () => { | ||
| const code = transformWith( | ||
| babel, | ||
| ` | ||
| function Box(props) { | ||
| return ( | ||
| <mesh {...props}> | ||
| <boxGeometry /> | ||
| <meshBasicMaterial /> | ||
| </mesh> | ||
| ); | ||
| } | ||
| `, | ||
| ) | ||
| expect(code).toMatchSnapshot() | ||
| }) | ||
|
|
||
| it('handles JSX member expressions', () => { | ||
| const code = transform( | ||
| ` | ||
| import { animated } from "@react-spring/three"; | ||
| it('handles JSX member expressions', () => { | ||
| const code = transformWith( | ||
| babel, | ||
| ` | ||
| import { animated } from "@react-spring/three"; | ||
|
|
||
| function Box(props) { | ||
| return ( | ||
| <animated.mesh {...props}> | ||
| <boxGeometry /> | ||
| <meshBasicMaterial /> | ||
| </animated.mesh> | ||
| ); | ||
| } | ||
| `, | ||
| ) | ||
| expect(code).toMatchSnapshot() | ||
| }) | ||
| function Box(props) { | ||
| return ( | ||
| <animated.mesh {...props}> | ||
| <boxGeometry /> | ||
| <meshBasicMaterial /> | ||
| </animated.mesh> | ||
| ); | ||
| } | ||
| `, | ||
| ) | ||
| expect(code).toMatchSnapshot() | ||
| }) | ||
|
|
||
| it('handles dynamic expressions', () => { | ||
| const code = transform( | ||
| ` | ||
| function Material(props) { | ||
| const Comp = props.foo ? 'meshBasicMaterial' : 'meshStandardMaterial'; | ||
| return <Comp color="royalblue" />; | ||
| } | ||
| `, | ||
| ) | ||
| expect(code).toMatchSnapshot() | ||
| }) | ||
| it('handles dynamic expressions', () => { | ||
| const code = transformWith( | ||
| babel, | ||
| ` | ||
| function Material(props) { | ||
| const Comp = props.foo ? 'meshBasicMaterial' : 'meshStandardMaterial'; | ||
| return <Comp color="royalblue" />; | ||
| } | ||
| `, | ||
| ) | ||
| expect(code).toMatchSnapshot() | ||
| }) | ||
|
|
||
| it('handles template strings', () => { | ||
| const code = transform( | ||
| ` | ||
| function Material(props) { | ||
| const Comp = \`mesh\$\{props.type\}Material\`; | ||
| return <Comp color="royalblue" />; | ||
| } | ||
| `, | ||
| ) | ||
| expect(code).toMatchSnapshot() | ||
| it('handles template strings', () => { | ||
| const code = transformWith( | ||
| babel, | ||
| ` | ||
| function Material(props) { | ||
| const Comp = \`mesh\$\{props.type\}Material\`; | ||
| return <Comp color="royalblue" />; | ||
| } | ||
| `, | ||
| ) | ||
| expect(code).toMatchSnapshot() | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.