FIX / PDF export for assignable asset groups

[Mary-Clb]

• I have performed a self-review of my code.
• I have added tests (when available) that prove my fix is effective or that my feature works.
• I have updated the CHANGELOG with a short functional description of the fix or new feature.
• This change requires a documentation update.

Description

• It fixes !43643
• This PR fixes PDF exports for assignable GLPI assets when group fields are loaded as arrays of IDs. The PDF plugin was still assuming that groups_id and groups_id_tech were always scalar values, while GLPI now loads these fields from glpi_groups_items as arrays for assignable items. As a result, group-related fields could be empty or incorrectly rendered in generated PDFs.
  The classes updated are the ones impacted beacause they correspond to assets implementing the AssignableItem feature.

Screenshots :

Before fix :

After fix :

[Rom1-B]

CHANGELOG please (always update it)

[stonebuzz]

I would recommend not adding a dedicated function to manage columns, rows, or labels for groups.

As it stands, only a very small portion of the plugin would actually use it, while the vast majority still relies on $pdf->displayLine().

Regarding the handling of multi-group assignments:

Group_Item, being a CommonDBRelation, provides the getItemsAssociatedTo method. This allows us to retrieve all groups associated with a given asset.

(Note that some assets may not have multiple groups.)

Therefore, the logic should be conditional:

if (!Toolbox::hasTrait(Asset::class, AssignableItem::class)) {

    Dropdown::getDropdownName(
        'glpi_groups',
        $item->fields['groups_id_tech']
    );

} else {

    $group_item = new Group_Item();
    $groups = $group_item->getItemsAssociatedTo(Asset::class, $items_id);

   //here filter groups depending of type (groups_id, groups_id_tech etc ...à

}

After that, the line can be constructed using displayLine.

[stonebuzz]

Better 🙂

However, we now have a significant amount of duplicated code. We should refactor and consolidate these methods into a single unified implementation.

[Mary-Clb]

@stonebuzz can I send it to the client ?

[Rom1-B]

Can you try this?:

Suggested change

	if (!Toolbox::hasTrait($item::class, AssignableItem::class)) {
	return Toolbox::stripTags(Dropdown::getDropdownName('glpi_groups', $item->fields[$field]));
	}
	$group_item = new Group_Item();
	$groups = $group_item->getItemsAssociatedTo($item::class, (int) $item->fields['id']);
	$group_ids = [];
	foreach ($groups as $group) {
	if ((int) $group->fields['type'] === $group_type) {
	$group_ids[] = (int) $group->fields['groups_id'];
	}
	}
	$group_ids = (array) ($item->fields[$field] ?? 0);