Use np.isin instead of np.in1d to fix numpy 2.4 test compatibility#5522
Merged
emilykl merged 3 commits intoplotly:mainfrom Apr 14, 2026
Merged
Use np.isin instead of np.in1d to fix numpy 2.4 test compatibility#5522emilykl merged 3 commits intoplotly:mainfrom
np.isin instead of np.in1d to fix numpy 2.4 test compatibility#5522emilykl merged 3 commits intoplotly:mainfrom
Conversation
Contributor
Author
|
The CI failure doesn't look related to this change. |
thunze
added a commit
to thunze/nixpkgs
that referenced
this pull request
Feb 23, 2026
`pytest_ignore_collect` takes only `collection_path` starting with pytest 9 [1]. Most of the paths referenced in `plotly/conftest.py` don't exist anymore and wouldn't be collected anyway, so we can just remove the file. Upstream PR: plotly/plotly.py#5522 [1] https://docs.pytest.org/en/latest/deprecations.html#py-path-local-arguments-for-hooks-replaced-with-pathlib-path
13 tasks
5 tasks
Contributor
|
Thanks for the PR! Could you please fill out the description post a bit more? It will be easier to review with more background information and any testing steps to verify that the change won't break anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numpy.in1dhas been deprecated since numpy 2.0 and was now removed with numpy 2.4 in favor ofnumpy.isin.For the two affected calls, the behavior of
numpy.in1dandnumpy.isinshould be equivalent, so I went ahead and replaced the usages ofnumpy.in1dwithnumpy.isin.Code PR
plotly.graph_objects, my modifications concern the code generator and not the generated files.