Repository navigation
Fix BIT value conversion - #83
Merged
Merged
Conversation
This was referenced Jun 16, 2026
maxenglander
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
Vitess exposes MySQL BIT columns as querypb.Type_BIT and VStream row values carry the raw bit bytes. In upstream Vitess, BIT is not an integral sqltypes.Value, so this connector takes the raw-byte branch. Go binary.Varint decodes a different signed varint format, causing values like 0x01, 0x80, and 0xff to serialize incorrectly or fail.
Validation