Skip to content

docs: clarify VGTID stop cursor handling #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvanw merged 1 commit into from
Jun 16, 2026
Merged

docs: clarify VGTID stop cursor handling #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions lib/connect_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,11 +349,9 @@ func (p connectClient) sync(ctx context.Context, logger DatabaseLogger, tableNam
tc = res.Cursor
}

// Because of the ordering of events in a vstream
// we receive the vgtid event first and then the rows.
// the vgtid event might repeat, but they're ordered.
// so we once we reach the desired stop vgtid, we stop the sync session
// if we get a newer vgtid.
// A single VGTID can appear in multiple ordered responses. Once we reach
// the desired stop VGTID, keep reading while the cursor stays there so all
// rows for that position are processed, then stop when a newer VGTID arrives.
watchForVgGtidChange = watchForVgGtidChange || tc.Position == stopPosition

if watchForVgGtidChange && tc.Position != stopPosition {
Expand Down