Support two-digit sidebar thread jumps#2623
Support two-digit sidebar thread jumps#2623svenbuild wants to merge 2 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 90fcd63. Configure here.
ApprovabilityVerdict: Needs human review This PR introduces new user-facing behavior (two-digit thread jump shortcuts) and modifies existing behavior by adding a 250ms delay to single-digit jumps while awaiting a potential second digit. New features with runtime behavior changes warrant human review. You can customize Macroscope's approvability policy. Learn more. |
90fcd63 to
667a308
Compare
667a308 to
70800d6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70800d6771
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Summary
Ctrl+9with labels likeCtrl+10andCtrl+15.thread.jump.1throughthread.jump.9keybinding commands unchanged.Why
This keeps the existing shortcut model but makes it work for longer thread lists without adding new keybinding commands.
Interaction notes
Ctrl+1still jumps to thread 1 after the short timeout.Ctrl+1, then5within the timeout jumps to visible thread 15.Ctrl+1,5without releasingCtrl.Verification
bun run test src/components/Sidebar.logic.test.tsfromapps/webbun run typecheck --filter=@t3tools/webgit diff --checkNote
Support two-digit keyboard thread jumps in sidebar navigation
buildThreadJumpLabelMapin Sidebar.tsx to generate composed shortcut labels (first-digit label + second digit character) for threads 10–99.Macroscope summarized c21f44f.
Note
Medium Risk
Updates the global sidebar keydown handler to add timed two-digit jump sequences and delays existing single-digit jumps by 250ms, which could subtly affect keyboard navigation behavior and event handling.
Overview
Adds two-digit sidebar thread-jump navigation (10–99) by capturing a second digit shortly after
thread.jump.1–thread.jump.9is triggered and computing the target visible thread index.Updates
buildThreadJumpLabelMapto synthesize and display shortcut hint labels for visible threads beyond 9 (e.g.,Ctrl+10,Ctrl+15), and introduces pending-jump state/timeout management that is cleared on navigation and route changes.Reviewed by Cursor Bugbot for commit c21f44f. Bugbot is set up for automated code reviews on this repo. Configure here.