Editables update#3829
Merged
Merged
Conversation
- Make `buttonText` optional in EditableEmptyPlaceholderProps (prop not rendered by component, missing in stories) - Extract type definitions from use-form-modal.tsx into form-modal-types.ts to stay under max-lines limit Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Use export…from to re-export ConfigUpdate directly (avoids import-then-re-export anti-pattern) - Remove redundant if-wrapper around switch in getDropZoneText to reduce cognitive complexity from 16 to 15 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- embed.url-modal.ok-text: OK → Save (translated per language) - embed.url-modal.warning: new key added - embed.placeholder: shortened text - video.placeholder: shortened text - Added date.placeholder, numeric.placeholder, select.placeholder, multiselect.placeholder Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Extract getElementType as a top-level utility function to remove its nested-function nesting penalty, bringing component complexity from 16 to below the 15 allowed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…hasContent) blocks Two separate if(hasContent) blocks with identical conditions each counted toward cognitive complexity. Merge into one block (search moved to always-first) to bring complexity from 16 to 15. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #
Additional info