Fix transport config#275
Open
bluvulture wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR cleans up the Docker transport configuration by removing the custom .docker/messenger.yaml override and its bind mounts. The hardcoded transports defined Pimcore messenger queues against a credential-less amqp://rabbitmq:5672/... DSN; deleting them lets Pimcore's default transports resolve via the existing PIMCORE_MESSENGER_TRANSPORT_DSN_PREFIX env var, while RabbitMQ and supervisord consumers stay intact.
Changes:
- Removed the entire transport definition block from
.docker/messenger.yaml. - Dropped the
messenger.yamlbind mounts from thephpandsupervisordservices indocker-compose.yaml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.docker/messenger.yaml |
Deleted custom AMQP transport overrides, deferring to Pimcore defaults driven by the DSN prefix env var. |
docker-compose.yaml |
Removed the read-only volume mounts injecting the custom messenger config into the php and supervisord containers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #264: messenger.yaml mounted empty in php/supervisord containers
.docker/messenger.yaml was bind-mounted over config/packages/messenger.yaml, a path that doesn't exist in the repo. Docker has to synthesize that mount point, and on some setups the nested single-file bind resolves to an empty file inside the container.
It also turns out the file is redundant: since the 2026.1 migration, Pimcore core builds the pimcore_core, pimcore_maintenance, pimcore_scheduled_tasks, pimcore_image_optimize and pimcore_asset_update transports from PIMCORE_MESSENGER_TRANSPORT_DSN_PREFIX, which the committed .env already sets to RabbitMQ. .docker/messenger.yaml just duplicated those same five transports - leftover from the Pimcore 11.x setup (#186) that was never removed.
Fix: delete .docker/messenger.yaml and its two bind mounts. Transport configuration now comes solely from .env + core, which is the intended 2026.x mechanism.