[Bug, EC] PEES-1104: Checkbox values is alway off in gridview#1124
Merged
Conversation
Ext.grid.column.Check hardcodes shouldUpdateCell() to always route in-place cell updates through its own updater(), which manipulates a <span>-based DOM structure incompatible with our custom renderer's nested-div markup, so the checked state visually fails to update (a full reload, e.g. via filtering, bypasses this path and shows the correct state).
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect checkbox rendering in Pimcore object grid views by adjusting the grid column configuration for the checkbox tag so displayed values reflect the underlying data correctly.
Changes:
- Remove
xtype: "checkcolumn"from the checkbox tag grid column config to rely on the custom renderer’s output.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves https://github.com/pimcore/service-operations/issues/844