[WIP] Improve auto-wrapping text - #254
Draft
m-roberts wants to merge 14 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #254 +/- ##
==========================================
+ Coverage 45.69% 45.73% +0.03%
==========================================
Files 50 50
Lines 1998 2005 +7
==========================================
+ Hits 913 917 +4
- Misses 1085 1088 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This pull request introduces 1 alert when merging d74b0db into deb159f - view on LGTM.com new alerts:
|
m-roberts
changed the title
Contributor
Author
|
This PR is quite old now. It's probably best used as guidance for how to write it properly rather than as the basis for an actual code submission |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #253
This is a draft PR, and is not final.
Still needs a clear strategy for how to find the maximum font size so that the whole text fits into the box, considering height and width (w/word wrapping)
Note: should have a minimum font size
TODOs:
https://github.com/pi-top/pi-top-Python-SDK/pull/254/files#diff-8ff4c1bbe8c2ef3c263d407574ea58158611e8d954011854873177db4d3346e4R20
https://github.com/pi-top/pi-top-Python-SDK/pull/254/files#diff-8ff4c1bbe8c2ef3c263d407574ea58158611e8d954011854873177db4d3346e4R62