Stub sealed array excluding valid cases

[PeterSmith8nss]

Array shapes generated for standard stubs are treated as sealed arrays by PHPStan 2,2. In some cases, the stub generator does not allow for all the elements that are allowed in those arrays, e.g. they are incorrectly sealed.

Two examples:

• get_categories - standard description only includes the first of the possible elements of $args, so PHPStan will flag an error if any of the other elements are provided
• add_settings_field - callback args may include other elements in addition to the two listed (see tradesouthwest example), these being of the designer's choice

I've modified the function map as follows:

• get_categories - added the argument parameter and set this as an unsealed array (as full list of elements would have been very long)
• add_settings_field - added to the function map, with $args as an unsealed array which it needs to be.

[szepeviktor]

@PeterSmith8nss I am so sorry. There is no label_for!

[PeterSmith8nss]

Latest commit has add_settings_field $args defined as 'args' => 'array{label_for?:string,class?:string,...}' which matches the definition:
$args
arrayoptional
Extra arguments that get passed to the callback function.

    label_for string
    When supplied, the setting title will be wrapped in a <label> element, its for attribute populated with this value.
    class string
    CSS Class to be added to the <tr> element when the field is output.

Default:array()

And include "label_for"

[szepeviktor]

I see. https://developer.wordpress.org/reference/functions/add_settings_field/#parameters

Thank you!

[IanDelMar]

php-stubs/wordpress-stubs typically does not allow query strings.

wordpress-stubs/src/Visitor.php

Lines 576 to 578 in 3945703

	// It's common for an args parameter to accept a query var string or array with `string|array`.
	// Remove the accepted string type for these so we get the strongest typing we can manage.
	$tagVariableType = str_replace(['|string', 'string|'], '', $tagVariableType);

[szepeviktor]

Thank you.
Do you thing about 8407351 ?