Conversation
Follow-up to 1b3e6ce: the design-mode toggle no longer swaps the pen-nib SVG for fa-code — only the title changes between CCB_SWITCH_TO_DESIGN_MODE and CCB_SWITCH_TO_CODE_EDITOR. Rewrite the existing icon-swap test to match the new behavior: still assert the title flips and that the button's is-active wiring works, but check that the SVG stays in both states instead of expecting an fa-code icon in design mode.
The hamburger menu's dropdown was anchored with `right: 0; left: auto`, which aligned its right edge with the toggle's right edge and made it extend leftward. In the narrow-titlebar layout that shows the hamburger the dropdown would spill over the central control bar, overlapping the editor / design-mode buttons. Flip to `left: 0; right: auto` so the dropdown's left edge aligns with the toggle and opens into the empty titlebar area on the right. Submenu arrows already point right (►), so submenu cascade direction is unchanged.
The CCB design-mode toggle had no visible active state beyond a title change, so it wasn't obvious the button was "on" without reading the tooltip. Add a subtle lighter background (rgba(255,255,255,0.12)) on .is-active to make the button read as a pressed toolbar chip, and bump the icon color one step brighter. No accent color — keeps the CCB's neutral palette intact.
…lbar - Replace the sprite-backed reload button with fa-arrow-rotate-right so it matches the weight of the other FA buttons in the toolbar. - Add #designModeToggleLivePreviewButton between reload and preview-mode that dispatches VIEW_TOGGLE_DESIGN_MODE, letting the user enter/exit design mode from the live-preview panel itself without reaching to the CCB. Icon swaps fa-expand ↔ fa-compress based on the current design-mode state, title swaps between CCB_SWITCH_TO_DESIGN_MODE and CCB_SWITCH_TO_CODE_EDITOR. - Hide #livePreviewModeBtn (the preview-mode dropdown) while in design mode — its options aren't meaningful when the editor is collapsed.
Replace the sprite-icon `leftArrow` / `rightArrow` / `leftArrowDisabled` / `rightArrowDisabled` bitmaps with fa-arrow-left / fa-arrow-right FA icons, matching the weight of the adjacent FA-based sidebar and toolbar buttons (binoculars, search, design-mode toggle) and giving the back/forward pair a browser-style affordance. NavigationProvider still toggles `.nav-back-btn` ↔ `.nav-back-btn-disabled` (and the forward pair) to signal enabled state. The CSS is rewritten as a single icon-button block with a .disabled opacity fork instead of four separate sprite rules.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.