Skip to content

Correct rounding in \pgf@sys@bp@correct - #1455

Merged
hmenke merged 4 commits into
pgf-tikz:masterfrom
hmenke:pgf@sys@bp@correct
Aug 1, 2026
Merged

Correct rounding in \pgf@sys@bp@correct#1455
hmenke merged 4 commits into
pgf-tikz:masterfrom
hmenke:pgf@sys@bp@correct

Conversation

@hmenke

@hmenke hmenke commented Jul 3, 2026

Copy link
Copy Markdown
Member

Motivation for this change

Fixes #1434

Checklist

Please signoff your commits to explicitly state your agreement to the Developer Certificate of Origin. If that is not possible you may check the boxes below instead:

@hmenke @Skillmon @josephwright
fix!(pgfsys): correct rounding in \pgf@sys@bp@correct
9ce3c07 
Co-authored-by: Jonathan Spratte <jspratte@yahoo.de>
Co-authored-by: Joseph Wright <joseph.wright@morningstar2.co.uk>
Signed-off-by: Henri Menke <henri@henrimenke.de>
@hmenke
hmenke requested review from josephwright and muzimuzhi July 3, 2026 11:08
@hmenke
hmenke force-pushed the pgf@sys@bp@correct branch 2 times, most recently from 5f1b546 to 6a99763 Compare July 3, 2026 12:06
josephwright
josephwright reviewed Jul 3, 2026
View reviewed changes

@josephwright josephwright left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@hmenke
hmenke force-pushed the pgf@sys@bp@correct branch from 6a99763 to 0038e3c Compare July 3, 2026 12:54
@hmenke
hmenke requested a review from Skillmon July 3, 2026 12:54
@hmenke
hmenke force-pushed the pgf@sys@bp@correct branch 2 times, most recently from de42925 to c85fcfb Compare July 3, 2026 13:53
Skillmon
Skillmon approved these changes Jul 3, 2026
View reviewed changes
Comment thread tex/generic/pgf/systemlayer/pgfsys.code.tex Outdated
Skillmon
Skillmon reviewed Jul 4, 2026
View reviewed changes
Comment thread tex/generic/pgf/systemlayer/pgfsys.code.tex Outdated
@hmenke
hmenke force-pushed the pgf@sys@bp@correct branch from c85fcfb to 0eb44d2 Compare July 4, 2026 07:51
@hmenke hmenke added this to the 3.1.12 milestone Jul 4, 2026
hmenke and others added 3 commits August 1, 2026 18:46
@hmenke
refactor(tests): simplify box test macros
8b68e8f 
Follow the proposal from l3build

Signed-off-by: Henri Menke <henri@henrimenke.de>
@pgf-tikz-bot @hmenke
tests: regenerate testfiles
e9af0e4 
Signed-off-by: Henri Menke <henri@henrimenke.de>
@pgf-tikz-bot @hmenke
tests: regenerate references
44aec62 
Signed-off-by: Henri Menke <henri@henrimenke.de>
@hmenke
hmenke force-pushed the pgf@sys@bp@correct branch 2 times, most recently from ba63891 to 44aec62 Compare August 1, 2026 18:44
@hmenke

hmenke commented Aug 1, 2026

Copy link
Copy Markdown
Member Author

@muzimuzhi There is a “bug” in check-commits. Even though the commit is signed off by the committer the check failed, because check-commits checks whether it was signed off by the author. I wrote “bug” in quotes, because I'm actually not sure what would the correct behavior here. Probably commits should be signed off by their author, but then still the message is wrong, because that currently refers to the committer.

@hmenke
hmenke merged commit f93509f into pgf-tikz:master Aug 1, 2026
9 of 10 checks passed
@muzimuzhi

muzimuzhi commented Aug 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Probably commits should be signed off by their author, but then still the message is wrong, because that currently refers to the committer.

@hmenke I'm not sure if signed-off by a bot (here pgf-tikz-bot) is meaningful. If not, we could adapt the pgf-tikz/actions/dco-check action so that a commit passes the check if it's signed-off by either its author or committer.

Or, we could simply whitelist the pgf-tikz-bot author, like how dependabot[bot] has been handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josephwright josephwright josephwright left review comments
@Skillmon Skillmon Skillmon approved these changes
@muzimuzhi muzimuzhi Awaiting requested review from muzimuzhi

Assignees

No one assigned

Labels

None yet

Milestone

3.1.12

Development

Successfully merging this pull request may close these issues.

pgf with \shade invalid pdf in Acrobat

5 participants

@hmenke @muzimuzhi @josephwright @Skillmon @pgf-tikz-bot