chore: resolve ansible facts deprecation notice

[jason-lynch]

Summary

Ansible is deprecating the default setting that populates some ansible facts into top-level ansible_ variables, such as ansible_architecture. This commit replaces our use of these variables with the ansible_facts equivalent.

Testing

This no longer produces a deprecation notice on the latest versions of ansible:

make dev-lima-deploy

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cdffa68d-c423-4c4e-adca-7b7f2c9f41ca

📥 Commits

Reviewing files that changed from the base of the PR and between 46cacdc and 0707792.

📒 Files selected for processing (6)

• e2e/fixtures/deploy_control_plane.yaml
• e2e/fixtures/roles/ec2_deploy/tasks/main.yaml
• e2e/fixtures/roles/install_prerequisites/tasks/main.yaml
• e2e/fixtures/setup_new_host.yaml
• e2e/fixtures/teardown_control_plane.yaml
• lima/roles/install_prerequisites/vars/main.yaml

---

📝 Walkthrough

Walkthrough

This pull request updates Ansible variable references across e2e test fixtures and Lima roles, migrating from legacy namespace conventions to the modern ansible_facts namespace. Changes include environment variables (SUDO_USER, HOME), Python executable paths, and architecture detection.

Changes

Cohort / File(s)	Summary
SUDO_USER Environment Variable Migration e2e/fixtures/deploy_control_plane.yaml, e2e/fixtures/roles/install_prerequisites/tasks/main.yaml, e2e/fixtures/teardown_control_plane.yaml	Migrates ansible_env.SUDO_USER references to ansible_facts.env.SUDO_USER in control-plane deployment, Docker socket configuration, and teardown tasks.
HOME Environment Variable Migration e2e/fixtures/setup_new_host.yaml	Updates Lima SSH config path construction to use ansible_facts.env.HOME instead of ansible_env.HOME.
Python Executable Path Migration e2e/fixtures/roles/ec2_deploy/tasks/main.yaml	Switches region-detection task's fallback interpreter from ansible_python.executable to ansible_facts.python.executable.
Architecture Lookup Migration lima/roles/install_prerequisites/vars/main.yaml	Updates etcd_archive_name and go_archive_name variables to source architecture from ansible_facts.architecture instead of ansible_architecture.

Poem

🐰 Hops through facts with glee,
Old namespaces restructured to be free,
From ansible_env to ansible_facts we dance,
Architecture, Python, HOME—all advance!
Modern Ansible paths now brightly gleam. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is incomplete. It lacks the Changes, Checklist, and Notes for Reviewers sections required by the template, though it includes Summary and Testing.	Add the missing 'Changes', 'Checklist', and 'Notes for Reviewers' sections from the template to provide complete documentation of the changeset.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'chore: resolve ansible facts deprecation notice' is clear, concise, and directly describes the main change: addressing an Ansible deprecation by updating variable references.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/ansible-facts-deprecation-notice

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[tsivaprasad]

Looks Good...!