revert: undo unrelated generated skill changes - #9
andrebrait merged 1 commit into
Conversation
Restore the complete original 0.9.57 fork tree at 6bda5d6. Skill installation and refresh require only the existing package installer, not a generated-runbook rewrite.
|
Reviewed head: Independent condensed review: APPROVE, no blockers (contract, correctness/hostile inputs, test honesty, and unnecessary complexity). Scope: retain the existing package and its generated skill unchanged; invoke only its existing agents installer after package upgrade. The owner explicitly requested undoing the unrelated generated-document changes. Evidence: independent scratch replay of the frozen bootstrap test produced 8 examples / 4 failures on the original bootstrap and 8 / 0 on the fix. A PATH-selection mutation produced 8 / 1, demonstrating the shadow-launcher guard is effective. The Graphify rollback restores the entire original Git tree 73f5d71611ad6ba1f53c3faedb5a67662ff175ef. All ten shared skill files match the original package. Actual isolated CLI installation and stale-content replacement passed. Canonical bootstrap gates passed, including full ShellSpec under dash; restored generator suite passed 65 tests and 134 generated artifacts match. Review concerns on PR Graphify-Labs#3268 about launcher selection and a vacuous shadow test are both resolved and mutation-tested. Earlier runbook findings are outside this narrowed task and their remediation was removed under the owner's explicit scope-reduction direction; they are not a reason to rewrite the vendor package again. |
|
@coderabbitai review |
There was a problem hiding this comment.
🟡 Changes recommended
Several updated documentation snippets are incorrect or unsafe (path quoting, inconsistent extraction ID examples, bypassing compatibility helpers, and credential handling), and some fixes require coordinated updates across regenerated artifacts.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates Graphify’s generated-skill documentation/artifacts to undo prior generated-skill changes, reverting multiple shell/reference snippets and regenerating the corresponding expected outputs and published skill reference files.
Changes:
- Adjusted skillgen shell and reference fragments (install/run snippets, extraction/query/export guidance).
- Regenerated
tools/skillgen/expected/*outputs to match updated fragments. - Updated the checked-in per-skill reference docs under
graphify/skills/*/references/.
File summaries
| File | Description |
|---|---|
| tools/skillgen/fragments/shell/powershell.md | PowerShell fragment tweaks for persisted interpreter/root paths |
| tools/skillgen/fragments/shell/posix.md | POSIX fragment tweaks for persisted interpreter/root paths |
| tools/skillgen/fragments/references/shared/transcribe.md | Transcribe reference strategy wording updated |
| tools/skillgen/fragments/references/shared/extraction-spec.md | Extraction spec sample JSON updated |
| tools/skillgen/fragments/references/shared/extraction-spec-compact.md | Compact extraction spec sample JSON updated |
| tools/skillgen/fragments/references/shared/exports.md | Neo4j export/push guidance updated |
| tools/skillgen/fragments/references/shared/add-watch.md | /graphify add and --watch reference updated |
| tools/skillgen/fragments/references/query/default.md | Query fallback snippet updated (NetworkX load path) |
| tools/skillgen/fragments/query-stub/default.md | Query stub command updated |
| tools/skillgen/expected/graphify__skills__windows__references__transcribe.md | Regenerated expected Windows transcribe reference |
| tools/skillgen/expected/graphify__skills__windows__references__query.md | Regenerated expected Windows query reference |
| tools/skillgen/expected/graphify__skills__windows__references__extraction-spec.md | Regenerated expected Windows extraction spec reference |
| tools/skillgen/expected/graphify__skills__windows__references__exports.md | Regenerated expected Windows exports reference |
| tools/skillgen/expected/graphify__skills__windows__references__add-watch.md | Regenerated expected Windows add/watch reference |
| tools/skillgen/expected/graphify__skills__vscode__references__transcribe.md | Regenerated expected VS Code transcribe reference |
| tools/skillgen/expected/graphify__skills__vscode__references__query.md | Regenerated expected VS Code query reference |
| tools/skillgen/expected/graphify__skills__vscode__references__exports.md | Regenerated expected VS Code exports reference |
| tools/skillgen/expected/graphify__skills__vscode__references__add-watch.md | Regenerated expected VS Code add/watch reference |
| tools/skillgen/expected/graphify__skills__trae__references__transcribe.md | Regenerated expected Trae transcribe reference |
| tools/skillgen/expected/graphify__skills__trae__references__query.md | Regenerated expected Trae query reference |
| tools/skillgen/expected/graphify__skills__trae__references__exports.md | Regenerated expected Trae exports reference |
| tools/skillgen/expected/graphify__skills__trae__references__add-watch.md | Regenerated expected Trae add/watch reference |
| tools/skillgen/expected/graphify__skills__pi__references__transcribe.md | Regenerated expected Pi transcribe reference |
| tools/skillgen/expected/graphify__skills__pi__references__query.md | Regenerated expected Pi query reference |
| tools/skillgen/expected/graphify__skills__pi__references__extraction-spec.md | Regenerated expected Pi extraction spec reference |
| tools/skillgen/expected/graphify__skills__pi__references__exports.md | Regenerated expected Pi exports reference |
| tools/skillgen/expected/graphify__skills__pi__references__add-watch.md | Regenerated expected Pi add/watch reference |
| tools/skillgen/expected/graphify__skills__opencode__references__transcribe.md | Regenerated expected OpenCode transcribe reference |
| tools/skillgen/expected/graphify__skills__opencode__references__query.md | Regenerated expected OpenCode query reference |
| tools/skillgen/expected/graphify__skills__opencode__references__exports.md | Regenerated expected OpenCode exports reference |
| tools/skillgen/expected/graphify__skills__opencode__references__add-watch.md | Regenerated expected OpenCode add/watch reference |
| tools/skillgen/expected/graphify__skills__kiro__references__transcribe.md | Regenerated expected Kiro transcribe reference |
| tools/skillgen/expected/graphify__skills__kiro__references__query.md | Regenerated expected Kiro query reference |
| tools/skillgen/expected/graphify__skills__kiro__references__extraction-spec.md | Regenerated expected Kiro extraction spec reference |
| tools/skillgen/expected/graphify__skills__kiro__references__exports.md | Regenerated expected Kiro exports reference |
| tools/skillgen/expected/graphify__skills__kiro__references__add-watch.md | Regenerated expected Kiro add/watch reference |
| tools/skillgen/expected/graphify__skills__kilo__references__transcribe.md | Regenerated expected Kilo transcribe reference |
| tools/skillgen/expected/graphify__skills__kilo__references__query.md | Regenerated expected Kilo query reference |
| tools/skillgen/expected/graphify__skills__kilo__references__exports.md | Regenerated expected Kilo exports reference |
| tools/skillgen/expected/graphify__skills__kilo__references__add-watch.md | Regenerated expected Kilo add/watch reference |
| tools/skillgen/expected/graphify__skills__droid__references__transcribe.md | Regenerated expected Droid transcribe reference |
| tools/skillgen/expected/graphify__skills__droid__references__query.md | Regenerated expected Droid query reference |
| tools/skillgen/expected/graphify__skills__droid__references__exports.md | Regenerated expected Droid exports reference |
| tools/skillgen/expected/graphify__skills__droid__references__add-watch.md | Regenerated expected Droid add/watch reference |
| tools/skillgen/expected/graphify__skills__copilot__references__transcribe.md | Regenerated expected Copilot transcribe reference |
| tools/skillgen/expected/graphify__skills__copilot__references__query.md | Regenerated expected Copilot query reference |
| tools/skillgen/expected/graphify__skills__copilot__references__exports.md | Regenerated expected Copilot exports reference |
| tools/skillgen/expected/graphify__skills__copilot__references__add-watch.md | Regenerated expected Copilot add/watch reference |
| tools/skillgen/expected/graphify__skills__codex__references__transcribe.md | Regenerated expected Codex transcribe reference |
| tools/skillgen/expected/graphify__skills__codex__references__query.md | Regenerated expected Codex query reference |
| tools/skillgen/expected/graphify__skills__codex__references__extraction-spec.md | Regenerated expected Codex extraction spec reference |
| tools/skillgen/expected/graphify__skills__codex__references__exports.md | Regenerated expected Codex exports reference |
| tools/skillgen/expected/graphify__skills__codex__references__add-watch.md | Regenerated expected Codex add/watch reference |
| tools/skillgen/expected/graphify__skills__claw__references__transcribe.md | Regenerated expected Claw transcribe reference |
| tools/skillgen/expected/graphify__skills__claw__references__query.md | Regenerated expected Claw query reference |
| tools/skillgen/expected/graphify__skills__claw__references__extraction-spec.md | Regenerated expected Claw extraction spec reference |
| tools/skillgen/expected/graphify__skills__claw__references__exports.md | Regenerated expected Claw exports reference |
| tools/skillgen/expected/graphify__skills__claw__references__add-watch.md | Regenerated expected Claw add/watch reference |
| tools/skillgen/expected/graphify__skills__claude__references__transcribe.md | Regenerated expected Claude transcribe reference |
| tools/skillgen/expected/graphify__skills__claude__references__query.md | Regenerated expected Claude query reference |
| tools/skillgen/expected/graphify__skills__claude__references__exports.md | Regenerated expected Claude exports reference |
| tools/skillgen/expected/graphify__skills__claude__references__add-watch.md | Regenerated expected Claude add/watch reference |
| tools/skillgen/expected/graphify__skills__amp__references__transcribe.md | Regenerated expected Amp transcribe reference |
| tools/skillgen/expected/graphify__skills__amp__references__query.md | Regenerated expected Amp query reference |
| tools/skillgen/expected/graphify__skills__amp__references__extraction-spec.md | Regenerated expected Amp extraction spec reference |
| tools/skillgen/expected/graphify__skills__amp__references__exports.md | Regenerated expected Amp exports reference |
| tools/skillgen/expected/graphify__skills__amp__references__add-watch.md | Regenerated expected Amp add/watch reference |
| tools/skillgen/expected/graphify__skills__agents__references__transcribe.md | Regenerated expected Agents transcribe reference |
| tools/skillgen/expected/graphify__skills__agents__references__query.md | Regenerated expected Agents query reference |
| tools/skillgen/expected/graphify__skills__agents__references__extraction-spec.md | Regenerated expected Agents extraction spec reference |
| tools/skillgen/expected/graphify__skills__agents__references__exports.md | Regenerated expected Agents exports reference |
| tools/skillgen/expected/graphify__skills__agents__references__add-watch.md | Regenerated expected Agents add/watch reference |
| graphify/skills/windows/references/transcribe.md | Updated published Windows transcribe reference |
| graphify/skills/windows/references/query.md | Updated published Windows query reference |
| graphify/skills/windows/references/extraction-spec.md | Updated published Windows extraction spec reference |
| graphify/skills/windows/references/exports.md | Updated published Windows exports reference |
| graphify/skills/windows/references/add-watch.md | Updated published Windows add/watch reference |
| graphify/skills/vscode/references/transcribe.md | Updated published VS Code transcribe reference |
| graphify/skills/vscode/references/query.md | Updated published VS Code query reference |
| graphify/skills/vscode/references/extraction-spec.md | Updated published VS Code extraction spec reference |
| graphify/skills/vscode/references/exports.md | Updated published VS Code exports reference |
| graphify/skills/vscode/references/add-watch.md | Updated published VS Code add/watch reference |
| graphify/skills/trae/references/transcribe.md | Updated published Trae transcribe reference |
| graphify/skills/trae/references/query.md | Updated published Trae query reference |
| graphify/skills/trae/references/extraction-spec.md | Updated published Trae extraction spec reference |
| graphify/skills/trae/references/exports.md | Updated published Trae exports reference |
| graphify/skills/trae/references/add-watch.md | Updated published Trae add/watch reference |
| graphify/skills/pi/references/transcribe.md | Updated published Pi transcribe reference |
| graphify/skills/pi/references/query.md | Updated published Pi query reference |
| graphify/skills/pi/references/extraction-spec.md | Updated published Pi extraction spec reference |
| graphify/skills/pi/references/exports.md | Updated published Pi exports reference |
| graphify/skills/pi/references/add-watch.md | Updated published Pi add/watch reference |
| graphify/skills/opencode/references/transcribe.md | Updated published OpenCode transcribe reference |
| graphify/skills/opencode/references/query.md | Updated published OpenCode query reference |
| graphify/skills/opencode/references/extraction-spec.md | Updated published OpenCode extraction spec reference |
| graphify/skills/opencode/references/exports.md | Updated published OpenCode exports reference |
| graphify/skills/opencode/references/add-watch.md | Updated published OpenCode add/watch reference |
| graphify/skills/kiro/references/transcribe.md | Updated published Kiro transcribe reference |
| graphify/skills/kiro/references/query.md | Updated published Kiro query reference |
| graphify/skills/kiro/references/extraction-spec.md | Updated published Kiro extraction spec reference |
| graphify/skills/kiro/references/exports.md | Updated published Kiro exports reference |
| graphify/skills/kiro/references/add-watch.md | Updated published Kiro add/watch reference |
| graphify/skills/kilo/references/transcribe.md | Updated published Kilo transcribe reference |
| graphify/skills/kilo/references/query.md | Updated published Kilo query reference |
| graphify/skills/kilo/references/extraction-spec.md | Updated published Kilo extraction spec reference |
| graphify/skills/kilo/references/exports.md | Updated published Kilo exports reference |
| graphify/skills/kilo/references/add-watch.md | Updated published Kilo add/watch reference |
| graphify/skills/droid/references/transcribe.md | Updated published Droid transcribe reference |
| graphify/skills/droid/references/query.md | Updated published Droid query reference |
| graphify/skills/droid/references/extraction-spec.md | Updated published Droid extraction spec reference |
| graphify/skills/droid/references/exports.md | Updated published Droid exports reference |
| graphify/skills/droid/references/add-watch.md | Updated published Droid add/watch reference |
| graphify/skills/copilot/references/transcribe.md | Updated published Copilot transcribe reference |
| graphify/skills/copilot/references/query.md | Updated published Copilot query reference |
| graphify/skills/copilot/references/extraction-spec.md | Updated published Copilot extraction spec reference |
| graphify/skills/copilot/references/exports.md | Updated published Copilot exports reference |
| graphify/skills/copilot/references/add-watch.md | Updated published Copilot add/watch reference |
| graphify/skills/codex/references/transcribe.md | Updated published Codex transcribe reference |
| graphify/skills/codex/references/query.md | Updated published Codex query reference |
| graphify/skills/codex/references/extraction-spec.md | Updated published Codex extraction spec reference |
| graphify/skills/codex/references/exports.md | Updated published Codex exports reference |
| graphify/skills/codex/references/add-watch.md | Updated published Codex add/watch reference |
| graphify/skills/claw/references/transcribe.md | Updated published Claw transcribe reference |
| graphify/skills/claw/references/query.md | Updated published Claw query reference |
| graphify/skills/claw/references/extraction-spec.md | Updated published Claw extraction spec reference |
| graphify/skills/claw/references/exports.md | Updated published Claw exports reference |
| graphify/skills/claw/references/add-watch.md | Updated published Claw add/watch reference |
| graphify/skills/claude/references/transcribe.md | Updated published Claude transcribe reference |
| graphify/skills/claude/references/query.md | Updated published Claude query reference |
| graphify/skills/claude/references/extraction-spec.md | Updated published Claude extraction spec reference |
| graphify/skills/claude/references/exports.md | Updated published Claude exports reference |
| graphify/skills/claude/references/add-watch.md | Updated published Claude add/watch reference |
| graphify/skills/amp/references/transcribe.md | Updated published Amp transcribe reference |
| graphify/skills/amp/references/query.md | Updated published Amp query reference |
| graphify/skills/amp/references/extraction-spec.md | Updated published Amp extraction spec reference |
| graphify/skills/amp/references/exports.md | Updated published Amp exports reference |
| graphify/skills/amp/references/add-watch.md | Updated published Amp add/watch reference |
| graphify/skills/agents/references/transcribe.md | Updated published Agents transcribe reference |
| graphify/skills/agents/references/query.md | Updated published Agents query reference |
| graphify/skills/agents/references/extraction-spec.md | Updated published Agents extraction spec reference |
| graphify/skills/agents/references/exports.md | Updated published Agents exports reference |
| graphify/skills/agents/references/add-watch.md | Updated published Agents add/watch reference |
Review details
- Files reviewed: 215/215 changed files
- Comments generated: 9
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| ```bash | ||
| $(cat graphify-out/.graphify_python) -m graphify query "<question>" | ||
| graphify query "<question>" |
There was a problem hiding this comment.
Not applied: this is the owner-requested exact rollback, not a new runbook revision. The owner explicitly directed: “Undo all the unnecessary stuff the previous agent did and implement it sanely.” The original package’s entire tracked tree is restored byte-for-byte to 6bda5d6 (tree 73f5d71611ad6ba1f53c3faedb5a67662ff175ef), independently verified.
The reported limitation is acknowledged and not represented as fixed. Reapplying generated-document changes in this rollback would defeat the explicit scope decision. The actual skill-refresh requirement is proven using the original package’s existing installer and is implemented separately in pfBlockerNG/pfBlockerNG#3268.
| import networkx as nx | ||
| from pathlib import Path | ||
|
|
||
| data = json.loads(Path('graphify-out/graph.json').read_text(encoding='utf-8')) | ||
| G = load_node_link_graph(data) | ||
| G = json_graph.node_link_graph(data, edges='links') |
There was a problem hiding this comment.
Not applied: this is the owner-requested exact rollback, not a new runbook revision. The owner explicitly directed: “Undo all the unnecessary stuff the previous agent did and implement it sanely.” The original package’s entire tracked tree is restored byte-for-byte to 6bda5d6 (tree 73f5d71611ad6ba1f53c3faedb5a67662ff175ef), independently verified.
The reported limitation is acknowledged and not represented as fixed. Reapplying generated-document changes in this rollback would defeat the explicit scope decision. The actual skill-refresh requirement is proven using the original package’s existing installer and is implemented separately in pfBlockerNG/pfBlockerNG#3268.
| ``` | ||
|
|
||
| Replace `URL` with the actual URL and pass the user's `AUTHOR` or `CONTRIBUTOR` when provided; use an empty string for either omitted value. If the command exits with an error, tell the user what went wrong - do not silently continue. After a successful save, automatically run the `--update` pipeline on the scan root recorded in `graphify-out/.graphify_root` to merge the new file into the existing graph. | ||
| Replace `URL` with the actual URL, `AUTHOR` with the user's name if provided, `CONTRIBUTOR` likewise. If the command exits with an error, tell the user what went wrong - do not silently continue. After a successful save, automatically run the `--update` pipeline on `./raw` to merge the new file into the existing graph. |
There was a problem hiding this comment.
Not applied: this is the owner-requested exact rollback, not a new runbook revision. The owner explicitly directed: “Undo all the unnecessary stuff the previous agent did and implement it sanely.” The original package’s entire tracked tree is restored byte-for-byte to 6bda5d6 (tree 73f5d71611ad6ba1f53c3faedb5a67662ff175ef), independently verified.
The reported limitation is acknowledged and not represented as fixed. Reapplying generated-document changes in this rollback would defeat the explicit scope decision. The actual skill-refresh requirement is proven using the original package’s existing installer and is implemented separately in pfBlockerNG/pfBlockerNG#3268.
|
|
||
| ```bash | ||
| $(cat graphify-out/.graphify_python) -m graphify.watch "INPUT_PATH" --debounce 3 | ||
| $(cat graphify-out/.graphify_python) -m graphify.watch INPUT_PATH --debounce 3 |
There was a problem hiding this comment.
Not applied: this is the owner-requested exact rollback, not a new runbook revision. The owner explicitly directed: “Undo all the unnecessary stuff the previous agent did and implement it sanely.” The original package’s entire tracked tree is restored byte-for-byte to 6bda5d6 (tree 73f5d71611ad6ba1f53c3faedb5a67662ff175ef), independently verified.
The reported limitation is acknowledged and not represented as fixed. Reapplying generated-document changes in this rollback would defeat the explicit scope decision. The actual skill-refresh requirement is proven using the original package’s existing installer and is implemented separately in pfBlockerNG/pfBlockerNG#3268.
| **If `--neo4j-push <uri>`** - push directly to a running Neo4j instance. Ask the user for credentials if not provided: | ||
|
|
||
| ```bash | ||
| NEO4J_PASSWORD="$("$(cat graphify-out/.graphify_python)" -c 'import getpass; print(getpass.getpass("Neo4j password: "))')" | ||
| export NEO4J_PASSWORD | ||
| graphify export neo4j --push bolt://localhost:7687 --user neo4j | ||
| unset NEO4J_PASSWORD | ||
| ``` | ||
|
|
||
| PowerShell: | ||
|
|
||
| ```powershell | ||
| $credential = Read-Host "Neo4j password" -AsSecureString | ||
| $env:NEO4J_PASSWORD = [System.Net.NetworkCredential]::new("", $credential).Password | ||
| graphify export neo4j --push bolt://localhost:7687 --user neo4j | ||
| Remove-Item Env:NEO4J_PASSWORD | ||
| graphify export neo4j --push bolt://localhost:7687 --user neo4j --password PASSWORD | ||
| ``` |
There was a problem hiding this comment.
Not applied: this is the owner-requested exact rollback, not a new runbook revision. The owner explicitly directed: “Undo all the unnecessary stuff the previous agent did and implement it sanely.” The original package’s entire tracked tree is restored byte-for-byte to 6bda5d6 (tree 73f5d71611ad6ba1f53c3faedb5a67662ff175ef), independently verified.
The reported limitation is acknowledged and not represented as fixed. Reapplying generated-document changes in this rollback would defeat the explicit scope decision. The actual skill-refresh requirement is proven using the original package’s existing installer and is implemented separately in pfBlockerNG/pfBlockerNG#3268.
| Node ID format: lowercase, only `[a-z0-9_]`, no dots or slashes. Format `{stem}_{entity}` where stem is the full repo-relative path with the extension dropped, every segment joined with `_` (each lowercased with non-alphanumeric chars replaced by `_`) and entity is the symbol name similarly normalized. Use every directory level, not just the immediate parent. `src/auth/session.py` + `ValidateToken` → `src_auth_session_validatetoken`. Top-level files use just the filename stem. This must match the AST extractor's ID. Never append chunk or sequence suffixes — IDs must be deterministic from the label alone. | ||
|
|
||
| Output exactly this JSON (no other text): | ||
| {"nodes":[{"id":"src_auth_session_validatetoken","label":"Human Readable Name","file_type":"code|document|paper|image|rationale|concept","source_file":"<FILE_LIST path verbatim>","source_location":null,"source_url":null,"captured_at":null,"author":null,"contributor":null}],"edges":[{"source":"node_id","target":"node_id","relation":"calls|implements|references|cites|conceptually_related_to|shares_data_with|semantically_similar_to|rationale_for","confidence":"EXTRACTED|INFERRED|AMBIGUOUS","confidence_score":1.0,"source_file":"<FILE_LIST path verbatim>","source_location":null,"weight":1.0}],"hyperedges":[{"id":"snake_case_id","label":"Human Readable Label","nodes":["node_id1","node_id2","node_id3"],"relation":"participate_in|implement|form","confidence":"EXTRACTED|INFERRED","confidence_score":0.75,"source_file":"<FILE_LIST path verbatim>"}],"input_tokens":0,"output_tokens":0} | ||
| {"nodes":[{"id":"auth_session_validatetoken","label":"Human Readable Name","file_type":"code|document|paper|image|rationale|concept","source_file":"<FILE_LIST path verbatim>","source_location":null,"source_url":null,"captured_at":null,"author":null,"contributor":null}],"edges":[{"source":"node_id","target":"node_id","relation":"calls|implements|references|cites|conceptually_related_to|shares_data_with|semantically_similar_to|rationale_for","confidence":"EXTRACTED|INFERRED|AMBIGUOUS","confidence_score":1.0,"source_file":"<FILE_LIST path verbatim>","source_location":null,"weight":1.0}],"hyperedges":[{"id":"snake_case_id","label":"Human Readable Label","nodes":["node_id1","node_id2","node_id3"],"relation":"participate_in|implement|form","confidence":"EXTRACTED|INFERRED","confidence_score":0.75,"source_file":"<FILE_LIST path verbatim>"}],"input_tokens":0,"output_tokens":0} |
There was a problem hiding this comment.
Not applied: this is the owner-requested exact rollback, not a new runbook revision. The owner explicitly directed: “Undo all the unnecessary stuff the previous agent did and implement it sanely.” The original package’s entire tracked tree is restored byte-for-byte to 6bda5d6 (tree 73f5d71611ad6ba1f53c3faedb5a67662ff175ef), independently verified.
The reported limitation is acknowledged and not represented as fixed. Reapplying generated-document changes in this rollback would defeat the explicit scope decision. The actual skill-refresh requirement is proven using the original package’s existing installer and is implemented separately in pfBlockerNG/pfBlockerNG#3268.
| Node ID format: lowercase, only `[a-z0-9_]`, no dots or slashes. Format: `{stem}_{entity}` where stem is the **full repo-relative path with the extension dropped**, every path segment kept and joined with `_` (each segment lowercased with non-alphanumeric chars replaced by `_`), and entity is the symbol name similarly normalized. Use every directory level, not just the immediate parent — this keeps same-named files in different directories distinct. Examples: `src/auth/session.py` + `ValidateToken` → `src_auth_session_validatetoken`; `lib/utils/helpers.py` + `parse_url` → `lib_utils_helpers_parse_url`; `tests/test_foo.py` + `_helper` → `tests_test_foo_helper`; `docs/v1/api/README.md` + `getUser` → `docs_v1_api_readme_getuser`. Top-level files (no parent dir, e.g. `setup.py`) use just the filename stem: `setup_my_func`. This must match the ID the AST extractor generates — using just the filename (e.g., `session_validatetoken`) or only the immediate parent (e.g., `auth_session_validatetoken`) will create orphan ghost-duplicate nodes. If you are re-extracting a project built under the old immediate-parent format, the user should run `graphify extract --force` to rebuild cleanly. CRITICAL: never append chunk numbers, sequence numbers, or any suffix to an ID (no `_c1`, `_c2`, `_chunk2`, etc.). IDs must be deterministic from the label alone — the same entity must always produce the same ID regardless of which chunk processes it. | ||
|
|
||
| Generate the extraction JSON matching this schema exactly: | ||
| {"nodes":[{"id":"src_auth_session_validatetoken","label":"Human Readable Name","file_type":"code|document|paper|image|rationale|concept","source_file":"<FILE_LIST path verbatim>","source_location":null,"source_url":null,"captured_at":null,"author":null,"contributor":null}],"edges":[{"source":"node_id","target":"node_id","relation":"calls|implements|references|cites|conceptually_related_to|shares_data_with|semantically_similar_to|rationale_for","confidence":"EXTRACTED|INFERRED|AMBIGUOUS","confidence_score":1.0,"source_file":"<FILE_LIST path verbatim>","source_location":null,"weight":1.0}],"hyperedges":[{"id":"snake_case_id","label":"Human Readable Label","nodes":["node_id1","node_id2","node_id3"],"relation":"participate_in|implement|form","confidence":"EXTRACTED|INFERRED","confidence_score":0.75,"source_file":"<FILE_LIST path verbatim>"}],"input_tokens":0,"output_tokens":0} | ||
| {"nodes":[{"id":"auth_session_validatetoken","label":"Human Readable Name","file_type":"code|document|paper|image|rationale|concept","source_file":"<FILE_LIST path verbatim>","source_location":null,"source_url":null,"captured_at":null,"author":null,"contributor":null}],"edges":[{"source":"node_id","target":"node_id","relation":"calls|implements|references|cites|conceptually_related_to|shares_data_with|semantically_similar_to|rationale_for","confidence":"EXTRACTED|INFERRED|AMBIGUOUS","confidence_score":1.0,"source_file":"<FILE_LIST path verbatim>","source_location":null,"weight":1.0}],"hyperedges":[{"id":"snake_case_id","label":"Human Readable Label","nodes":["node_id1","node_id2","node_id3"],"relation":"participate_in|implement|form","confidence":"EXTRACTED|INFERRED","confidence_score":0.75,"source_file":"<FILE_LIST path verbatim>"}],"input_tokens":0,"output_tokens":0} |
There was a problem hiding this comment.
Not applied: this is the owner-requested exact rollback, not a new runbook revision. The owner explicitly directed: “Undo all the unnecessary stuff the previous agent did and implement it sanely.” The original package’s entire tracked tree is restored byte-for-byte to 6bda5d6 (tree 73f5d71611ad6ba1f53c3faedb5a67662ff175ef), independently verified.
The reported limitation is acknowledged and not represented as fixed. Reapplying generated-document changes in this rollback would defeat the explicit scope decision. The actual skill-refresh requirement is proven using the original package’s existing installer and is implemented separately in pfBlockerNG/pfBlockerNG#3268.
| # Save scan root so `graphify update` (no args) knows where to look next time | ||
| echo "$(cd "INPUT_PATH" && pwd)" > graphify-out/.graphify_root | ||
| echo "$(cd INPUT_PATH && pwd)" > graphify-out/.graphify_root |
There was a problem hiding this comment.
Not applied: this is the owner-requested exact rollback, not a new runbook revision. The owner explicitly directed: “Undo all the unnecessary stuff the previous agent did and implement it sanely.” The original package’s entire tracked tree is restored byte-for-byte to 6bda5d6 (tree 73f5d71611ad6ba1f53c3faedb5a67662ff175ef), independently verified.
The reported limitation is acknowledged and not represented as fixed. Reapplying generated-document changes in this rollback would defeat the explicit scope decision. The actual skill-refresh requirement is proven using the original package’s existing installer and is implemented separately in pfBlockerNG/pfBlockerNG#3268.
| # Save scan root so `graphify update` (no args) knows where to look next time | ||
| [System.IO.File]::WriteAllText((Join-Path $PWD 'graphify-out\.graphify_root'), (Resolve-Path "INPUT_PATH").Path, $Utf8NoBom) | ||
| [System.IO.File]::WriteAllText((Join-Path $PWD 'graphify-out\.graphify_root'), (Resolve-Path INPUT_PATH).Path, $Utf8NoBom) |
There was a problem hiding this comment.
Not applied: this is the owner-requested exact rollback, not a new runbook revision. The owner explicitly directed: “Undo all the unnecessary stuff the previous agent did and implement it sanely.” The original package’s entire tracked tree is restored byte-for-byte to 6bda5d6 (tree 73f5d71611ad6ba1f53c3faedb5a67662ff175ef), independently verified.
The reported limitation is acknowledged and not represented as fixed. Reapplying generated-document changes in this rollback would defeat the explicit scope decision. The actual skill-refresh requirement is proven using the original package’s existing installer and is implemented separately in pfBlockerNG/pfBlockerNG#3268.
|
All nine Copilot findings are acknowledged: recorded-interpreter query routing, NetworkX compatibility helper, add/update scan root, watch-path quoting, Neo4j password guidance, two extraction-ID examples, POSIX scan-root quoting, and PowerShell LiteralPath. Each thread records the same owner-directed rollback disposition; none is claimed fixed by this PR. Not applied: this is the owner-requested exact rollback, not a new runbook revision. The owner explicitly directed: “Undo all the unnecessary stuff the previous agent did and implement it sanely.” The original package’s entire tracked tree is restored byte-for-byte to 6bda5d6 (tree 73f5d71611ad6ba1f53c3faedb5a67662ff175ef), independently verified. The reported limitation is acknowledged and not represented as fixed. Reapplying generated-document changes in this rollback would defeat the explicit scope decision. The actual skill-refresh requirement is proven using the original package’s existing installer and is implemented separately in pfBlockerNG/pfBlockerNG#3268. |
|
@coderabbitai review |
|
Final gate at |
ea8d3c4
into
issue/3254-refresh-graphify-fork-0.9.57
Summary
Undo the 13 generated-skill remediation commits added after the original pfBlockerNG 0.9.57 package pin. The owner requested removal of the unnecessary scope expansion.
This is a reversible revert: the complete tracked tree returns to
6bda5d6a4bc0d18d83573bd3ade5769c918ddf6a. It preserves the original 0.9.57 fork functionality and adds no replacement generator logic. PR #8 was closed without merging.The actual requirement is addressed solely by invoking the existing skill installer after package upgrade in pfBlockerNG/pfBlockerNG#3268.
Verification
New test-first proof is not applicable to this exact rollback and restoration of its original tests; no novel behavior is introduced.