fix: harden generated Graphify commands - #7
Merged
andrebrait merged 1 commit intoSep 10, 2026
Merged
andrebrait merged 1 commit into
andrebrait merged 1 commit into
Conversation
Member
Author
|
@coderabbitai review |
Member
Author
|
@coderabbitai review |
There was a problem hiding this comment.
🟡 Changes recommended
The Windows split-platform core is PowerShell but the referenced on-demand add/watch reference content remains bash-fenced/$(cat ...)-based, so PowerShell parity is still broken for that workflow.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR hardens the generated Graphify “skill” artifacts so command snippets consistently use the recorded interpreter (graphify-out/.graphify_python) and pass URL/author/contributor metadata via argv instead of embedding user-provided strings directly in Python source.
Changes:
- Extend the POSIX→PowerShell core translator to also rewrite
$(cat graphify-out/.graphify_python) -m graphify ...invocations for PowerShell hosts. - Update
/graphify addsnippets to takeURL,AUTHOR, andCONTRIBUTORviasys.argv[...]and update the associated guidance text. - Update generator contract tests and refresh expected/generated skill artifacts accordingly.
File summaries
| File | Description |
|---|---|
| tools/skillgen/gen.py | Adds argv-close mapping for URL metadata and translates -m graphify calls to PowerShell in bash-fence translation. |
| tools/skillgen/fragments/references/shared/add-watch.md | Switches ingest snippet to argv-based URL/author/contributor passing and updates instructions. |
| tools/skillgen/fragments/query-stub/default.md | Uses the recorded interpreter to run graphify query. |
| tools/skillgen/fragments/core/devin.md | Updates the embedded ingest snippet to argv-based metadata passing. |
| tools/skillgen/fragments/core/core.md | Runs export commands via recorded interpreter (-m graphify export ...). |
| tools/skillgen/fragments/core/aider.md | Updates the embedded ingest snippet to argv-based metadata passing. |
| tools/skillgen/expected/graphify__skills__windows__references__add-watch.md | Updates expected snapshot for add-watch ingest argv passing. |
| tools/skillgen/expected/graphify__skills__vscode__references__add-watch.md | Updates expected snapshot for add-watch ingest argv passing. |
| tools/skillgen/expected/graphify__skills__trae__references__add-watch.md | Updates expected snapshot for add-watch ingest argv passing. |
| tools/skillgen/expected/graphify__skills__pi__references__add-watch.md | Updates expected snapshot for add-watch ingest argv passing. |
| tools/skillgen/expected/graphify__skills__opencode__references__add-watch.md | Updates expected snapshot for add-watch ingest argv passing. |
| tools/skillgen/expected/graphify__skills__kiro__references__add-watch.md | Updates expected snapshot for add-watch ingest argv passing. |
| tools/skillgen/expected/graphify__skills__kilo__references__add-watch.md | Updates expected snapshot for add-watch ingest argv passing. |
| tools/skillgen/expected/graphify__skills__droid__references__add-watch.md | Updates expected snapshot for add-watch ingest argv passing. |
| tools/skillgen/expected/graphify__skills__copilot__references__add-watch.md | Updates expected snapshot for add-watch ingest argv passing. |
| tools/skillgen/expected/graphify__skills__codex__references__add-watch.md | Updates expected snapshot for add-watch ingest argv passing. |
| tools/skillgen/expected/graphify__skills__claw__references__add-watch.md | Updates expected snapshot for add-watch ingest argv passing. |
| tools/skillgen/expected/graphify__skills__claude__references__add-watch.md | Updates expected snapshot for add-watch ingest argv passing. |
| tools/skillgen/expected/graphify__skills__amp__references__add-watch.md | Updates expected snapshot for add-watch ingest argv passing. |
| tools/skillgen/expected/graphify__skills__agents__references__add-watch.md | Updates expected snapshot for add-watch ingest argv passing. |
| tools/skillgen/expected/graphify__skill.md | Updates expected snapshot for interpreter-based export/query commands. |
| tools/skillgen/expected/graphify__skill-windows.md | Updates expected snapshot for PowerShell interpreter-based export/query commands. |
| tools/skillgen/expected/graphify__skill-vscode.md | Updates expected snapshot for interpreter-based export/query commands. |
| tools/skillgen/expected/graphify__skill-trae.md | Updates expected snapshot for interpreter-based export/query commands. |
| tools/skillgen/expected/graphify__skill-pi.md | Updates expected snapshot for interpreter-based export/query commands. |
| tools/skillgen/expected/graphify__skill-opencode.md | Updates expected snapshot for interpreter-based export/query commands. |
| tools/skillgen/expected/graphify__skill-kiro.md | Updates expected snapshot for interpreter-based export/query commands. |
| tools/skillgen/expected/graphify__skill-kilo.md | Updates expected snapshot for interpreter-based export/query commands. |
| tools/skillgen/expected/graphify__skill-droid.md | Updates expected snapshot for interpreter-based export/query commands. |
| tools/skillgen/expected/graphify__skill-devin.md | Updates expected snapshot for argv-based ingest snippet. |
| tools/skillgen/expected/graphify__skill-copilot.md | Updates expected snapshot for interpreter-based export/query commands. |
| tools/skillgen/expected/graphify__skill-codex.md | Updates expected snapshot for interpreter-based export/query commands. |
| tools/skillgen/expected/graphify__skill-claw.md | Updates expected snapshot for interpreter-based export/query commands. |
| tools/skillgen/expected/graphify__skill-amp.md | Updates expected snapshot for interpreter-based export/query commands. |
| tools/skillgen/expected/graphify__skill-aider.md | Updates expected snapshot for argv-based ingest snippet. |
| tools/skillgen/expected/graphify__skill-agents.md | Updates expected snapshot for interpreter-based export/query commands. |
| tests/test_skillgen.py | Adds assertions for argv-based ingest snippet and interpreter-based export/query commands. |
| graphify/skills/windows/references/add-watch.md | Updates generated windows add-watch reference to argv-based ingest call. |
| graphify/skills/vscode/references/add-watch.md | Updates generated vscode add-watch reference to argv-based ingest call. |
| graphify/skills/trae/references/add-watch.md | Updates generated trae add-watch reference to argv-based ingest call. |
| graphify/skills/pi/references/add-watch.md | Updates generated pi add-watch reference to argv-based ingest call. |
| graphify/skills/opencode/references/add-watch.md | Updates generated opencode add-watch reference to argv-based ingest call. |
| graphify/skills/kiro/references/add-watch.md | Updates generated kiro add-watch reference to argv-based ingest call. |
| graphify/skills/kilo/references/add-watch.md | Updates generated kilo add-watch reference to argv-based ingest call. |
| graphify/skills/droid/references/add-watch.md | Updates generated droid add-watch reference to argv-based ingest call. |
| graphify/skills/copilot/references/add-watch.md | Updates generated copilot add-watch reference to argv-based ingest call. |
| graphify/skills/codex/references/add-watch.md | Updates generated codex add-watch reference to argv-based ingest call. |
| graphify/skills/claw/references/add-watch.md | Updates generated claw add-watch reference to argv-based ingest call. |
| graphify/skills/claude/references/add-watch.md | Updates generated claude add-watch reference to argv-based ingest call. |
| graphify/skills/amp/references/add-watch.md | Updates generated amp add-watch reference to argv-based ingest call. |
| graphify/skills/agents/references/add-watch.md | Updates generated agents add-watch reference to argv-based ingest call. |
| graphify/skill.md | Updates generated core skill to use recorded interpreter for export/query commands. |
| graphify/skill-windows.md | Updates generated PowerShell core skill to use recorded interpreter for export/query commands. |
| graphify/skill-vscode.md | Updates generated core skill to use recorded interpreter for export/query commands. |
| graphify/skill-trae.md | Updates generated core skill to use recorded interpreter for export/query commands. |
| graphify/skill-pi.md | Updates generated core skill to use recorded interpreter for export/query commands. |
| graphify/skill-opencode.md | Updates generated core skill to use recorded interpreter for export/query commands. |
| graphify/skill-kiro.md | Updates generated core skill to use recorded interpreter for export/query commands. |
| graphify/skill-kilo.md | Updates generated core skill to use recorded interpreter for export/query commands. |
| graphify/skill-droid.md | Updates generated core skill to use recorded interpreter for export/query commands. |
| graphify/skill-devin.md | Updates generated monolith to argv-based ingest snippet. |
| graphify/skill-copilot.md | Updates generated core skill to use recorded interpreter for export/query commands. |
| graphify/skill-codex.md | Updates generated core skill to use recorded interpreter for export/query commands. |
| graphify/skill-claw.md | Updates generated core skill to use recorded interpreter for export/query commands. |
| graphify/skill-amp.md | Updates generated core skill to use recorded interpreter for export/query commands. |
| graphify/skill-aider.md | Updates generated monolith to argv-based ingest snippet. |
| graphify/skill-agents.md | Updates generated core skill to use recorded interpreter for export/query commands. |
Review details
- Files reviewed: 67/67 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| try: | ||
| out = ingest('URL', Path('./raw'), author='AUTHOR', contributor='CONTRIBUTOR') | ||
| out = ingest(sys.argv[1], Path('./raw'), author=sys.argv[2] or None, contributor=sys.argv[3] or None) |
Member
Author
|
Copilot did not respond to the review request. CodeRabbit did not respond to the initial request or the one permitted retry. The required independent condensed adversarial review approved the exact head after independently reproducing the red contract and verifying all generated artifacts. |
andrebrait
merged commit Sep 10, 2026
f984fb5
into
issue/3254-refresh-graphify-fork-0.9.57
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.graphify_pythonVerification
uv run pytest tests/test_skillgen.py -q: 67 passeduv run python -m tools.skillgen --check: 134 artifacts matchuv run ruff check tools/skillgen/gen.py tests/test_skillgen.pypassesgraphify update .completedFollow-up to #6 and andrebrait/ai-harness-settings#2.