Rename -NormalizeNewline to -NormalizeLineEnding - #2969
Merged
Conversation
…nd Should-NotBeString -NormalizeLineEnding is the more generic and correct name, it normalizes \r\n, \r and the Unicode line separator, not just \n. Renaming now while it is only in 6.1.0-rc1 avoids shipping the less accurate name in a stable release. Fixes pester#2967 🤖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-NormalizeLineEndingis more generic and correct, the switch normalizes\r\n,\rand the Unicode line separator, not just\n. It is only in 6.1.0-rc1 so far, so renaming it now keeps the less accurate name out of a stable release.Renamed on
Should-BeStringandShould-NotBeString(and the sharedTest-StringEqual), tests updated. Help text is unchanged, it already described the behavior generically.Fixes #2967
🤖