fix: cache the update check timestamp when the version lookup fails - #3846
Merged
frostming merged 1 commit intoAug 17, 2026
Merged
Conversation
get_latest_version() returned early when the PyPI lookup raised, before writing the "last-check" entry to the self-check cache. A failed check was therefore never cached, so every subsequent command retried the request and waited out the connection timeout again, making pdm appear to hang for users who are offline or behind a restrictive network. Record the check time whether or not the lookup succeeded, so a failure backs off for the same expiry window as a success. Fixes pdm-project#3840
frostming
approved these changes
Aug 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3846 +/- ##
=======================================
Coverage 88.36% 88.36%
=======================================
Files 121 121
Lines 13249 13249
Branches 2251 2251
=======================================
Hits 11708 11708
Misses 969 969
Partials 572 572
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3840
get_latest_version()returned early when the PyPI lookup raised, before writingthe
last-checkentry to the self-check cache. A failed check was therefore nevercached, so every subsequent command retried the request and waited out the
connection timeout again — making pdm appear to hang for users who are offline or
behind a restrictive network.
This records the check time whether or not the lookup succeeded, so a failure
backs off for the same expiry window as a success.
latest-versionis still onlywritten on success, so the cached-hit path now reads it with
.get().Added a regression test asserting that a second call within the expiry window does
not re-hit the network, plus a news fragment.