perf: bypass redundant NetworkX wrapper checks to optimize graph building loops (#798)#802
Open
suhaniiz wants to merge 1 commit into
Open
perf: bypass redundant NetworkX wrapper checks to optimize graph building loops (#798)#802suhaniiz wants to merge 1 commit into
suhaniiz wants to merge 1 commit into
Conversation
|
@suhaniiz is attempting to deploy a commit to the param20h's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 PR Checklist
🔗 Related Issue
Closes #798
📝 What does this PR do?
Optimizes performance inside the entity co-occurrence mapping loop within
build_graphby removing redundant hash lookups.Previously, the code invoked explicit wrapper methods (
graph.has_node(...)andgraph.has_edge(...)) sequentially before modifying attributes. This pattern forced NetworkX to execute multiple duplicate lookups across internal dictionary states on every element traversal.This PR optimizes lookups by:
entity.id in graph.nodes).right_id in graph[left_id]).This significantly lowers lookup overhead when constructing high-density knowledge graphs from heavy multi-page payloads.
🗂️ Type of Change
🧪 How was this tested?
mentions,weight,chunks,pages) accurately.📸 Screenshots (if UI change)
N/A (Performance optimization)
No breaking architectural changes. The approach leans on standard, idiomatic Python dictionary lookup operations, remaining completely compatible with NetworkX's core internal graph dictionary structures.
✅ Self-Review Checklist
dev, notmainmainbranch or any HuggingFace deployment config