fix: resolve state mutation by cloning graph before json conversion in save_graph (#796)#800
Open
suhaniiz wants to merge 1 commit into
Open
fix: resolve state mutation by cloning graph before json conversion in save_graph (#796)#800suhaniiz wants to merge 1 commit into
suhaniiz wants to merge 1 commit into
Conversation
|
@suhaniiz is attempting to deploy a commit to the param20h's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@param20h , kindly review this, it is under gssoc! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 PR Checklist
🔗 Related Issue
Closes #796
📝 What does this PR do?
Resolves a silent state mutation bug where processing sequential document chunks in memory caused an unhandled
AttributeError.The
build_graphfunction was calling_convert_sets_for_json(graph)right before returning, which mutated the underlying graph's node/edge properties (pagesandchunks) from mutable Pythonsetstructures into sortedliststructures. Consequently, subsequent in-memory operations attempting to call.add()on these properties failed.This PR removes the mutation call from
build_graphand safely decouples serialization by calling_convert_sets_for_json()on a shallow clone (graph.copy()) insidesave_graphright before writing to disk.🗂️ Type of Change
🧪 How was this tested?
📸 Screenshots (if UI change)
N/A (Backend logic fix)
The fix uses a lightweight
graph.copy()shallow copy from NetworkX insidesave_graph. This ensures we don't manipulate the core operational graph being actively processed or maintained in memory while fully isolating the structural type adjustments needed strictly for JSON compliance.✅ Self-Review Checklist
dev, notmainmainbranch or any HuggingFace deployment config