Repository navigation
Conversation
Contributor
|
Thanks for the pull request, @2Zest! It's linked to #71940, which is currently assigned to @JMBorrill, who's already working on it. We keep one contributor per issue to avoid duplicated effort. If @JMBorrill has had no activity for 7 days, the issue is released automatically and you'll then be able to claim it with I've closed this pull request for now — none of your work is lost. Once #71940 is assigned to you, ask a maintainer to reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71940
Summary
Groupby and resample
ohlcreductions on pyarrow-backed numeric arrays produce a two-dimensional masked result. The Arrow conversion helper attempted to construct a one-dimensional Arrow array from that result and raisedValueError: Mask must be 1D array.Multi-output reductions now keep the delegated masked result so the data manager can split it into the four output columns. One-dimensional reductions continue to convert back to the original Arrow dtype.
Tests
python -m compileall -q pandas/core/arrays/arrow/array.py pandas/tests/groupby/aggregate/test_aggregate.pypython -m pytest pandas/tests/groupby/aggregate/test_aggregate.py -k test_ohlc_pyarrow_dtype -q(blocked locally because the in-place pandas extension modulepandas._libs.pandas_parseris not built)git diff --checkI used OpenAI Codex to develop this pull request, reviewed and understood every change, and included the regression test.