Repository navigation
Conversation
Contributor
|
Thanks for the pull request, @2Zest! It's linked to #71941, but that issue isn't assigned to you yet. To make sure two people don't unknowingly work on the same thing, we ask contributors to claim an issue first. You can comment This pull request is unlikely to be reviewed until #71941 is assigned to you. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71941
Summary
DataFrame.to_sqldocuments timedelta values as nanoseconds, but the SQL insertion path views the native timedelta buffer directly. Since pandas 3 usestimedelta64[us]by default, values were written 1,000 times too small.The insertion path now converts NumPy-backed timedeltas to
timedelta64[ns]before extracting integer values. Arrow-backed timedeltas already used the nanosecond conversion and remain unchanged.Tests
python -m compileall -q pandas/io/sql.py pandas/tests/io/test_sql.pypython -m pytest pandas/tests/io/test_sql.py -k test_to_sql_timedelta_writes_nanoseconds -q(blocked locally because the in-place pandas extension modulepandas._libs.pandas_parseris not built)git diff --checkI used OpenAI Codex to develop this pull request, reviewed and understood every change, and included the regression test.