Repository navigation
DOC: explain BusinessHour carry-over for non-whole-hour business hours (GH#60596) - #71951
Draft
jbrockmendel wants to merge 1 commit into
Draft
jbrockmendel wants to merge 1 commit into
jbrockmendel wants to merge 1 commit into
Conversation
…s (GH#60596) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #60596
BusinessHour(n)advances byn * 60minutes of business time, so part of an hour that does not fit before closing continues from the next opening. With business hours that are not a whole number of hours long (e.g.09:30-16:00), adate_rangedrifts off the opening time after the first day. This is intended, and additive (ts + BH(2) == ts + BH() + BH()), but only shown indirectly in the user guide and not mentioned in the docstrings.BusinessHour/CustomBusinessHourdocstrings: one sentence plus an example of the carry-over.date_rangeexample, and a note that a 24-hour business day can't be expressed, pointing to filtering an hourly range onday_of_weekinstead (the use case in the issue).GH-42399 reports the same behavior.
AI disclosure: drafted with Claude Code (
claude opus 5.5 (high)), which investigated the issue, confirmed the behavior is by design, and wrote the doc changes.