Skip to content

Assembly lifetime fix net10 - #247

Open
knightfall wants to merge 4 commits into
pamidur:masterfrom
knightfall:assembly-lifetime-fix-net10
Open

knightfall wants to merge 4 commits into
pamidur:masterfrom
knightfall:assembly-lifetime-fix-net10

Conversation

@knightfall

Copy link
Copy Markdown

Hi @pamidur,
Raising this PR to solve #244.
Changed the behavior with the help Codex/Gpt 6.1 Sol to do the following:

  • Dispose assembly and symbols on every exit path including processing fails and no op
  • Processing op opens the target directly instead of using it from the persistent dependecy cache
  • Scoped target registration makes self-references and dependency back-references resolve to the active target
  • Async void tests wait for tracked completion and propagate failures to the test.
    This will likely add some minor overheads but I haven't benchmarked it yet.
    I have asked codex to create a proof of the fix which can be read here: Reference cycle reproduction

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant