Repository navigation
enabling slots fills - #1437
Open
rishiz27 wants to merge 8 commits into
Open
enabling slots fills#1437rishiz27 wants to merge 8 commits into
rishiz27 wants to merge 8 commits into
Conversation
added 8 commits
October 28, 2026 21:51
…approval-extension # Conflicts: # server/handler/pull_request_review.go # server/handler/pull_request_review_test.go # server/handler/slots_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
Repositories cannot supply their own slot fills while extending a shared approval policy
After this PR
Adds approval_extends(using slots) so repos can use a shared approval policy and customize its slots with their own rules. For example, the shared policy can require platform approval, and a repo can add service and security approval through a slot. That repo would then need all 3. Repo fills can replace a slots defaults but they cant remove shared requirements outside the slots
Possible downsides?