Repository navigation
Fix courtyard batching check after generative furniture - #76
Merged
Merged
Conversation
Pushable furniture keeps one group per piece by design, so table seating from #74 pushed the courtyard section past the 40-child budget meant to catch unbatched window meshes. Counting meshes keeps that check intact. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main has been red since #74:
tests/courtyard.test.tsassertedsection.group.children.length < 40to catch unbatched window meshes. Since #69, each pushable furniture piece is its own group, and #74's table seating added more pushable chairs. The ground courtyard on tape 199307 now has 27 batched meshes and 14 furniture groups.The assertion now counts only meshes (27 < 40), so the window-batching check keeps its meaning and no longer depends on how much movable furniture a room gets.
Verification:
npm testpasses 249/249 on current main.🤖 Generated with Claude Code