feat(mcp): #33 add is_rejected_with_code and because_message_equals#35
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #33.
Summary
Two thin additions to
AssertableMCPthat close gaps in the fluent error vocabulary:is_rejected_with_code(code: int)— assert arbitrary JSON-RPC error codes (custom application-level codes outside the spec set, e.g.-32001for auth failures).because_message_equals(expected: str)— exact match sibling of the existingbecause_message_contains(substr).Both compose inside
assert_mcp(lambda m: ...), eliminating the need to drop intoassert_json("error", ...)for custom error codes or strict message matching.Before / after
Implementation
_expect_error_codesignature fromErrorCodetoint | ErrorCode(no behavior change — internal already usedint(expected)).is_rejected_with_codeis a 2-line public wrapper over the internal helper.because_message_equalsmirrorsbecause_message_containswith==and consistent error-message wording ("Error message does not match X: Y").Test plan
is_rejected_with_codehappy + sad path + "no error envelope" branch.because_message_equalshappy + sad path + "no error envelope" branch.