issue #222: fix audio stream stutter btween ovelay TS file;#233
Open
suzp1984 wants to merge 1 commit into
Open
issue #222: fix audio stream stutter btween ovelay TS file;#233suzp1984 wants to merge 1 commit into
suzp1984 wants to merge 1 commit into
Conversation
suzp1984
commented
Nov 21, 2024
suzp1984
commented
Contributor
- let continuity_counter continually between overlay ts;
- copy audio data when transcoding ts;
suzp1984
force-pushed
the
issue/222-transcript-audio-stream
branch
from
November 21, 2024 17:12
559676a to
580c403
Compare
Contributor
Author
|
This PR try to fix #222 . Here is how I verify this PR. Because I didn't has openAI account to run the whole process. I change the code first by remove the openAI api and render the ASR to video stream code, then I can reproduce same problem described in #222. Then I add this PR, the issue disappear. So I guess this PR works. Send it to review and let others to verify on real env. |
suzp1984
marked this pull request as ready for review
November 21, 2024 17:18
suzp1984
force-pushed
the
issue/222-transcript-audio-stream
branch
2 times, most recently
from
November 25, 2024 06:27
fadc636 to
364276b
Compare
1. let continuity_counter continually between overlay ts; 2. copy audio data when transcoding ts;
suzp1984
force-pushed
the
issue/222-transcript-audio-stream
branch
from
November 25, 2024 06:41
364276b to
abdcf82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.