Skip to content

Fix for broken CI badge and CI .yaml refactoring - #125

Merged
aaronchongth merged 3 commits into
osrf:masterfrom
cardboardcode:bug/fix_broken_badge
Aug 13, 2026
Merged

Fix for broken CI badge and CI .yaml refactoring#125
aaronchongth merged 3 commits into
osrf:masterfrom
cardboardcode:bug/fix_broken_badge

Conversation

@cardboardcode

Copy link
Copy Markdown
Collaborator

Purpose 🔖

This Pull Request (PR) is to address the long-standing broken CI link found on the root README.md as well as introduced simple refactoring of both .workflow.yml CI files under .github/workflows/ directory.

Why the refactoring?

dev.workflow.yml is to build and deploy the documentation. Renaming it to github-pages.yml as well as its action name to GitHub pages makes it more apparent on first glance what it is doing.

The above also seems to be what the broken markdown badge is point to. 🔍

prod.workflow.yml is only to evaluate incoming PRs and their build results. Renaming it to pull-request.yml and its action name also helps make its operation obvious.

…e terms.

Signed-off-by: Gary Bey <beyhy94@gmail.com>
Signed-off-by: Gary Bey <beyhy94@gmail.com>
@cardboardcode cardboardcode self-assigned this Aug 11, 2026

@aaronchongth aaronchongth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix! LGTM

@aaronchongth
aaronchongth merged commit efc728d into osrf:master Aug 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants