You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Added the dictionary and json file for the Thermo-Fischer Neptune Plus instrument.
Also modified the latools.cfg to add the config files under the config name: "NEPTUNE".
Quick question: how confident are you that this file format is universal for all Neptunes? If there's a chance it might vary, could you rename your config entry and dataformat file to be institute-specific? For example, see how the 'ANU-iCAP-RQ' file is named. This will avoid potential confusion later.
My pleasure!
I have absolutely no idea about this, I will ask around my institute, especially the technicians, if there are some differences.
Actually, there is a small mistake in the regex for the column_id. I realised that the one that I just submitted does is for "Mass Name" followed by "Mass Number", but the raw Neptune plus output is actually the reverse. I know you have a small function to reverse it, but I am just better off changing it manually here.
I will change the name to NP_GU, is that better?
I will submit the changes to it soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the dictionary and json file for the Thermo-Fischer Neptune Plus instrument.
Also modified the latools.cfg to add the config files under the config name: "NEPTUNE".