Repository navigation
Conversation
These helpers are library entry points for manage_lsp and tests, not registered IPC commands.
Collaborator
Author
|
Superseded by #1960, which stacks this commit with the other unused-code cleanups. |
Harry19081
added
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Twenty-three LSP helpers still used
#[tauri::command]even though they are not inhandler_list.inc/generate_handler!. Frontend never invoked those names. Agent tools already call the same functions as a library (manage_lsp) or talk toLspManagerdirectly.Solution
Strip the unused
#[tauri::command]macros and update comments so these stay library helpers. Do not deleteLspManager,manage_lsp, orquery_lsp. IPC registration is unchanged because these commands were never registered.Potential risks
The functions remain public crate API, including State-taking wrappers that nothing currently calls. A later cleanup can delete those wrappers; this PR only removes the false IPC surface. HTTP e2e test routes that drive
LspManagerdirectly are unaffected.Verification
cargo check -p lsp— passedlsppassedcargo test -p lsp/ org2 binary check / manage_lsp e2e (no function bodies changed)