Skip to content

chore(sql-editor): remove unused query editor - #1948

Merged
FresnelR27 merged 1 commit into
developfrom
chore/remove-unused-sql-editor
Sep 18, 2026
Merged

FresnelR27 merged 1 commit into
developfrom
chore/remove-unused-sql-editor

Conversation

@beruro

@beruro beruro commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Problem

SqlQueryEditor / QueryResults were never mounted in production after DatabaseManager moved to .archive. The unused feature still shipped a CodeMirror SQL stack (@codemirror/lang-sql, sql-formatter), a db_run_query shortcut, and dedicated i18n keys.

Solution

Delete the unused SqlEditor files and barrel exports. Remove the SQL-only packages, the db_run_query shortcut, and the strings that only that UI referenced (sqlEditor.*, SQL tooltips, actions.run). Keep placeholders.noQueryResults, which is still used by the shared Placeholder component.

Potential risks

If Database query UI is revived, this editor has to be restored from git history. .archive still points at the old import path and will not compile if someone un-archives it without bringing the editor back. Opening .sql files in the regular CodeMirror editor is unchanged; that path never used @codemirror/lang-sql.

Verification

  • pnpm exec vitest run --config config/vitest.config.ts src/app/root/__tests__/startupGraph.test.ts src/app/root/__tests__/featureBoundaries.test.ts src/config/keyboard/shortcutBindings.test.ts src/config/keyboard/shortcutDisplay.test.ts — 4 files, 58 tests passed
  • pnpm check:i18n-keys — passed (0 new unused/missing keys)
  • Commit hook: lint-staged, oxlint, eslint, prettier, and staged TypeScript check passed
  • NOT RUN: full pnpm test / pnpm lint / browser Database UI (feature is unmounted; no user-visible surface remains)

The SQL editor was never mounted after DatabaseManager moved to archive.
Drop the feature plus its packages, shortcut, and unused strings.
@FresnelR27
FresnelR27 merged commit 5984416 into develop Sep 18, 2026
15 checks passed
@Harry19081 Harry19081 added maintenance Maintenance, CI, build, release, cleanup, or tooling work dev-tooling Developer tooling, build, CI, tests, diagnostics, or release labels Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-tooling Developer tooling, build, CI, tests, diagnostics, or release maintenance Maintenance, CI, build, release, cleanup, or tooling work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants