Repository navigation
chore(sql-editor): remove unused query editor - #1948
Merged
Merged
Conversation
The SQL editor was never mounted after DatabaseManager moved to archive. Drop the feature plus its packages, shortcut, and unused strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SqlQueryEditor/QueryResultswere never mounted in production after DatabaseManager moved to.archive. The unused feature still shipped a CodeMirror SQL stack (@codemirror/lang-sql,sql-formatter), adb_run_queryshortcut, and dedicated i18n keys.Solution
Delete the unused SqlEditor files and barrel exports. Remove the SQL-only packages, the
db_run_queryshortcut, and the strings that only that UI referenced (sqlEditor.*, SQL tooltips,actions.run). Keepplaceholders.noQueryResults, which is still used by the shared Placeholder component.Potential risks
If Database query UI is revived, this editor has to be restored from git history.
.archivestill points at the old import path and will not compile if someone un-archives it without bringing the editor back. Opening.sqlfiles in the regular CodeMirror editor is unchanged; that path never used@codemirror/lang-sql.Verification
pnpm exec vitest run --config config/vitest.config.ts src/app/root/__tests__/startupGraph.test.ts src/app/root/__tests__/featureBoundaries.test.ts src/config/keyboard/shortcutBindings.test.ts src/config/keyboard/shortcutDisplay.test.ts— 4 files, 58 tests passedpnpm check:i18n-keys— passed (0 new unused/missing keys)pnpm test/pnpm lint/ browser Database UI (feature is unmounted; no user-visible surface remains)