Repository navigation
refactor(workstation): remove unreachable My Station code - #1841
Merged
Merged
Conversation
Delete code with no live caller, each traced before removal: - Tab bar: the bottom-panel and DevTools toggles (the first rendered nothing at its five mounts, the second was never mounted), FileHeader.beforeMoreMenuSlot, two StatusBarCallbacks fields and the never-passed more-options button. - Workstation tokens: HEADER_HEIGHT, three tab-bar row classes, SECTION_ACTION_BUTTON, ROW_BUTTON, unused HEADER_BUTTON keys and PANEL_CONSTANTS fields. - Sidebar sections: PanelSectionHeader, the tab dropdown that could never open, globalSection, headerSlot, widthClass and showTopBorder. - CodeEditor: the FileSearchPanel overlay with its state and handlers, the indexing-progress pipeline and status-bar indicator, IDE_APP_CONFIG and updateCachedFileMtime. - i18n: the ten message keys only those removals referenced.
hbrls
pushed a commit
to nice-fungal/ORG2
that referenced
this pull request
Sep 29, 2026
Add the architecture audit of My Station (behaviour defects, findings by area, suggested PR waves) and the companion UI audit of its 36px bars and sidebars (21 fix, 8 abstract, 12 keep with reason, 1 watch). Both reports note what the follow-up PRs apply: org2AI#1838 (inset motion only on station toggle, no chat header rule) and org2AI#1841 (unreachable code removal).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An audit of My Station traced UI, state and helpers that no production path reaches. They keep dead contracts alive and mislead anyone reading the code:
onToggleBottomPanelcallback has had no writer since the panels were archived. Its DevTools twin is never mounted.FileHeader.beforeMoreMenuSlotexisted only to host the toggle.TabBar.onMoreOptionsis never passed, so the more-options button never renders.src/config/workstation/tokens.tsexportsHEADER_HEIGHT = 40, documented as the height of every Workstation header although it has no importers and every bar is 36px, plus several other unreferenced tokens and keys.PrimarySidebarLayoutWithSectionscarries a tab dropdown that cannot open and three props with no callers;PanelSectionHeaderhas no consumers.FileSearchPaneloverlay that nothing can open. The indexing-progress atoms have no writers, so the status-bar indexing indicator can never appear.IDE_APP_CONFIGandupdateCachedFileMtimehave no production callers.Solution
Delete the unreachable code and everything that existed only to feed it. Each item was traced to zero live callers, importers or passers before removal.
TabBarTrailingControls.tsxand its test, the five mounts and barrel export,FileHeader.beforeMoreMenuSlot,StatusBarCallbacks.onToggleBottomPanelandbottomPanelCollapsed, and the more-options button with itsonMoreOptionsprop.HEADER_HEIGHT,TAB_BAR_CONTROLS_ROW_BASE_CLASS,TAB_BAR_CONTROLS_ROW_PADDING_TRAILING_ONLY,TAB_BAR_CONTROLS_ROW_CLASS,SECTION_ACTION_BUTTON,ROW_BUTTON, nine unusedHEADER_BUTTONkeys,SEARCH_TAB_ROW_CLASSES.withBorderand five unusedPANEL_CONSTANTSfields. Two inset constants are un-exported and stale "Used by" docs are removed. The class strings for the two remainingHEADER_BUTTONkeys are unchanged.PanelSectionHeader, the never-openable tab dropdown, theglobalSection,headerSlotandwidthClassprops,CollapsibleSection.showTopBorder(only the removed global section passed it) and a title special case for an action key that does not exist.FileSearchPaneloverlay with its visibility state, four handlers and theonSearchClicksidebar prop; the indexing-progress atoms,useIndexingIndicatorand the status-bar indicator;IDE_APP_CONFIG;updateCachedFileMtimeand its tests.check:i18n-keysreports no new unused keys.No runtime behavior is intended to change. This PR is independent of #1838 and can merge in either order.
Potential risks
check:i18n-keys.panel.toggleBottomaction and Spotlight entry (removing them removes a visible no-op command), the project tab-bar search chain, the shortcut bridge with its unreachable Save / Don't Save dialog (to be decided with the ⌘W close-guard fix), unreachable Browser tab code, constant replay placeholder helpers and theWorkStation/Canvasmodule.Verification
node_modules/.bin/prettier --check,node_modules/.bin/oxlint -c .oxlintrc.json --max-warnings 0andnode_modules/.bin/eslint --max-warnings 0 --report-unused-disable-directiveson the 30 changed TypeScript files: all pass.node_modules/.bin/tsgo --noEmit --pretty false: exit 0.node_modules/.bin/vitest run --config config/vitest.config.tsoversrc/modules/WorkStation,src/store/workstation,src/store/ui/workStationLayout,src/modules/shared/components/FileHeader,src/modules/shared/layoutsand the six dependent suites outside them (CanvasApp.test.ts,CanvasApp.share.test.ts,SubagentPipCard.lifecycle.test.ts,ProjectManagerContentRouter.test.ts,SidebarSettingsMenuButton.test.ts,scrollbarStyleContract.test.ts): 248 files, 1,554 tests passed.node scripts/quality/i18n-keys/check.mjs: missing 0; unused 0 new (13 current, 19 baselined).node scripts/quality/check-test-placement.mjs: consistent.git diff --check: clean..gitis a file, so the "Pre-commit hook ran." trailer is not appended.check:typed-lint, and the app itself. No screenshots, because the removed code never rendered anything visible; the one possible layout effect is listed under Potential risks.