Repository navigation
ci(ios-release): support ad hoc distribution - #1833
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The iOS release workflow only accepts App Store Connect provisioning profiles and always exports with
app-store-connect. The resulting IPA can be uploaded to TestFlight but cannot be installed through Pgyer on registered devices.Solution
Add an
ad-hocdistribution choice to the existing iOS release workflow while keeping App Store Connect as the default. The workflow selects the dedicated Ad Hoc profile, validates that it contains registered devices and disables debugging, generates matching export options, and validates the exported IPA against the selected distribution method. TestFlight upload remains restricted to App Store Connect packages.Potential risks
Ad Hoc builds install only on devices embedded in the selected provisioning profile; the current profile contains one registered iPhone. Adding devices later requires regenerating the profile and rebuilding. The existing App Store Connect path remains the default and retains its prior profile and upload checks.
Verification
node --test scripts/ios-release/manual-signing.test.mjs scripts/ios-release/readiness.test.mjs— passed, 33 testsgit diff --check— passed.github/workflows/ios-testflight.ymlsuccessfullydevelopbranch first