Skip to content

fix(chat): collapse answered questions and running terminals - #1827

Merged
FresnelR27 merged 1 commit into
developfrom
dev/chat-panel-collapse-defaults
Sep 15, 2026
Merged

FresnelR27 merged 1 commit into
developfrom
dev/chat-panel-collapse-defaults

Conversation

@Harry19081

Copy link
Copy Markdown
Member

Problem

Answered question cards can remain expanded when the existing pending history row transitions to answered because the collapse hook reads its default only on mount. Ongoing terminal cards also default to expanded, causing command input and output to occupy the chat timeline.

Solution

Collapse chat question history when an interaction transitions into the answered state, while preserving manual expansion and existing simulator behavior. Make terminal command cards collapsed by default for running, backgrounded, and settled commands; users can still expand a row manually, and settled transitions continue to collapse it.

Potential risks

Ongoing terminal output is no longer visible until its row is expanded, though lifecycle status and the stop control remain available in the header. Explicit per-event collapse state and simulator presentation are preserved. The full repository typecheck remains affected by unrelated existing errors described below.

Verification

  • pnpm exec vitest run --config config/vitest.config.ts src/engines/ChatPanel/events/interactive_events/ask-question/__tests__/AskQuestionEvent.collapse.test.ts src/engines/ChatPanel/events/interactive_events/ask-question/__tests__/extractAnsweredData.test.ts src/engines/ChatPanel/blocks/TerminalBlock/collapsePolicy.test.ts — passed, 3 files / 18 tests
  • pnpm exec eslint src/engines/ChatPanel/events/interactive_events/ask-question/index.tsx src/engines/ChatPanel/events/interactive_events/ask-question/__tests__/AskQuestionEvent.collapse.test.ts src/engines/ChatPanel/blocks/TerminalBlock/index.tsx src/engines/ChatPanel/blocks/TerminalBlock/collapsePolicy.test.ts — passed
  • git diff --check — passed for the in-scope changes
  • NODE_OPTIONS=--max-old-space-size=8192 pnpm typecheck — not clean because of unrelated existing errors in src/components/SearchInput/SearchInput.test.ts and ChatGroupMeta.hasBody references in the pre-existing chat-group changes
  • Visual evidence: no additional screenshot is attached because this is a state-only compactness change; the supplied issue screenshot documents the before state, and the DOM regression test verifies the resulting collapsed state

@FresnelR27
FresnelR27 merged commit 60948ba into develop Sep 15, 2026
14 checks passed
@Harry19081 Harry19081 added UX Improvements to user experience, workflow smoothness chat Chat, composer, markdown, canvas, browser, or terminal surfaces labels Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chat Chat, composer, markdown, canvas, browser, or terminal surfaces UX Improvements to user experience, workflow smoothness

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants