Repository navigation
fix(search-input): accept nullable shared refs - #1824
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The shared
SearchInputtest renders a heterogeneous[SearchInput, ReplaceInput]component list with one React ref type. Full TypeScript checking rejected the call atSearchInput.test.ts:79becauseReplaceInputProps.inputRefexcludednull, while React refs are nullable before mount and after unmount. The two component prop contracts therefore produced incompatible generic ref types.Solution
Allow
nullin theReplaceInputinput-ref element union. This alignsReplaceInputwith React's ref lifecycle and the existingSearchInputcontract while preserving all runtime behavior.Potential risks
Risk is limited to a compile-time type widening; rendering and ref assignment are unchanged. Mounted refs still point only to
HTMLInputElementorHTMLTextAreaElement. No screenshot is useful because this change has no visual behavior.Verification
pnpm exec vitest run --config config/vitest.config.ts src/components/SearchInput/SearchInput.test.ts— passed, 1 file and 2 testsNODE_OPTIONS=--max-old-space-size=8192 pnpm exec tsc --noEmit --pretty false— passed; the default 4 GB attempt exhausted the Node heap before producing TypeScript diagnosticsgit diff --check origin/develop...HEAD— passed