Skip to content

feat(settings): add bundled license viewer - #1819

Merged
FresnelR27 merged 3 commits into
developfrom
dev/settings-license-viewer
Sep 15, 2026
Merged

FresnelR27 merged 3 commits into
developfrom
dev/settings-license-viewer

Conversation

@Chloe-JY

@Chloe-JY Chloe-JY commented Sep 15, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The app’s General settings had no in-app license viewer, and a hand-maintained modal would drift whenever the repository license changed.

Solution

Added a bottom-of-General “View license” row and shared modal. The modal requests app_license_read on open; the Tauri command embeds the repository root LICENSE at compile time, so each rebuilt app displays the exact license shipped from the source without duplicated frontend text. Added localized UI strings across supported settings catalogs and frontend/Rust regression coverage. The license content area explicitly allows deep text selection for copying.

Potential risks

The license is compiled into the desktop binary, so a changed LICENSE appears only in newly built/released versions; an already-installed binary remains intentionally unchanged. If the runtime IPC command is unavailable, the modal shows a localized load error. Full repository typecheck still has an unrelated existing src/components/SearchInput/SearchInput.test.ts:79 error, and the repository i18n check has an unrelated existing unused simulator title-bar key.

Verification

  • pnpm exec prettier --check on changed TypeScript/JSON — passed
  • Focused ESLint on changed TypeScript/test files — passed
  • pnpm test -- src/api/tauri/license.test.ts — passed (1 test)
  • CARGO_TARGET_DIR=/tmp/orgii-codex-settings-target cargo test -p settings — passed (16 tests)
  • cargo check -p org2 --lib — passed
  • pnpm build — passed
  • pnpm run check:test-placement — passed
  • rustfmt --check --edition 2021 src-tauri/crates/settings/src/commands.rs — passed
  • pnpm check:i18n-keys — feature keys clean (localeGaps: 0); command exits 1 on unrelated sessions:simulator.titleBar.showBottomPanel
  • pnpm typecheck — command exits 2 on unrelated pre-existing src/components/SearchInput/SearchInput.test.ts:79 TS2769; the default run also hit the Node heap limit before rerun with 8 GB
  • Follow-up verification: all 12 non-English settings catalogs now contain translated license strings; the modal content wrapper uses the app’s deep-selection utility
  • Manual source audit — shared Button/Modal used, long license text scrollable and selectable, no new raw/substitute click controls; no GUI screenshot/recording was run because the repository AGENTS explicitly prohibits computer-use unless requested and the user did not request it

The repository-link audit found remaining old YORG-AI/ORGII references in the committed tree; those are outside this focused PR and are listed separately in the handoff.

Pre-commit hook ran. Total eslint: 0, total circular: 4
Pre-commit hook ran. Total eslint: 0, total circular: 4
@FresnelR27
FresnelR27 merged commit 13f5caa into develop Sep 15, 2026
15 checks passed
@Harry19081 Harry19081 added enhancement New feature or request frontend-ui Frontend UI, design system, accessibility, layout, or theming labels Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend-ui Frontend UI, design system, accessibility, layout, or theming

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants