Repository navigation
feat(settings): add bundled license viewer - #1819
Merged
Merged
Conversation
Pre-commit hook ran. Total eslint: 0, total circular: 4
Pre-commit hook ran. Total eslint: 0, total circular: 4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The app’s General settings had no in-app license viewer, and a hand-maintained modal would drift whenever the repository license changed.
Solution
Added a bottom-of-General “View license” row and shared modal. The modal requests
app_license_readon open; the Tauri command embeds the repository rootLICENSEat compile time, so each rebuilt app displays the exact license shipped from the source without duplicated frontend text. Added localized UI strings across supported settings catalogs and frontend/Rust regression coverage. The license content area explicitly allows deep text selection for copying.Potential risks
The license is compiled into the desktop binary, so a changed
LICENSEappears only in newly built/released versions; an already-installed binary remains intentionally unchanged. If the runtime IPC command is unavailable, the modal shows a localized load error. Full repository typecheck still has an unrelated existingsrc/components/SearchInput/SearchInput.test.ts:79error, and the repository i18n check has an unrelated existing unused simulator title-bar key.Verification
pnpm exec prettier --checkon changed TypeScript/JSON — passedpnpm test -- src/api/tauri/license.test.ts— passed (1 test)CARGO_TARGET_DIR=/tmp/orgii-codex-settings-target cargo test -p settings— passed (16 tests)cargo check -p org2 --lib— passedpnpm build— passedpnpm run check:test-placement— passedrustfmt --check --edition 2021 src-tauri/crates/settings/src/commands.rs— passedpnpm check:i18n-keys— feature keys clean (localeGaps: 0); command exits 1 on unrelatedsessions:simulator.titleBar.showBottomPanelpnpm typecheck— command exits 2 on unrelated pre-existingsrc/components/SearchInput/SearchInput.test.ts:79TS2769; the default run also hit the Node heap limit before rerun with 8 GBThe repository-link audit found remaining old
YORG-AI/ORGIIreferences in the committed tree; those are outside this focused PR and are listed separately in the handoff.