AB#289456 - OverlayMessaging tweaks - #102
Merged
Merged
Conversation
vvoicehovics
force-pushed
the
289456/lower-session-length-overlay
branch
from
July 20, 2026 11:53
1ba4bbd to
7796330
Compare
vvoicehovics
changed the title
vvoicehovics
approved these changes
Aug 7, 2026
samt-optimove
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rule out against builder pattern for overlay settings, we dont expect amount of setting to grow significantly --> mb an overkill. API is different from swift where arg labels are idiomatic.
enableOverlayMessaging(int sessionLengthHours)is unchanged for backwards compatibility. Later we can deprecate it.Counterpart for optimove-tech/Optimove-SDK-iOS#142