Treat SimTK String as std;;string across the swig interface.#4335
Open
aymanhab wants to merge 1 commit into
Open
Treat SimTK String as std;;string across the swig interface.#4335aymanhab wants to merge 1 commit into
aymanhab wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #4324
Brief summary of changes
This PR tells SWIG to treat SimTK::String as an std::string across the interface. Due to the fact that SimTK::String has an implicit conversion this should not cause problems. Besides no old interfaces are affected, only methods with SimTK::String in signature are now available to scripting.
Testing I've completed
Check signature of SWIG generated java files and they looked correct/usable.
Looking for feedback on...
CHANGELOG.md (choose one)
This change is