Adding otp-e2e tests on periodic jobs for hive#77906
Open
miyadav wants to merge 2 commits intoopenshift:mainfrom
Open
Adding otp-e2e tests on periodic jobs for hive#77906miyadav wants to merge 2 commits intoopenshift:mainfrom
miyadav wants to merge 2 commits intoopenshift:mainfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/hold
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds a new periodic CI test configuration and corresponding Prow periodic job for OpenShift Hive (AWS IPI long-duration), plus two base_images entries and an update to cluster-profile allowlist to authorize the Hive repo for the aws-qe profile. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 8 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (8 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Member
Author
|
/pj-rehearse periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa |
Contributor
|
@miyadav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: miyadav The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/pj-rehearse periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa |
Contributor
|
@miyadav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@ci-operator/jobs/openshift/hive/openshift-hive-master-periodics.yaml`:
- Around line 2-84: This job (name:
periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa)
is missing a reporter_config block; add a reporter_config at the job level
mirroring the other Hive periodic jobs so failures are sent to Slack (include
the slack reporter settings: slack channel, cluster/cluster alias labels and the
secret reference for the Slack webhook), ensuring the reporter_config key and
its slack subkeys match the schema used by the other Hive periodics in this
file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 79a62e74-be49-41cb-9e6a-88bfecac9d3a
📒 Files selected for processing (3)
ci-operator/config/openshift/hive/openshift-hive-master__periodic.yamlci-operator/jobs/openshift/hive/openshift-hive-master-periodics.yamlci-operator/step-registry/cluster-profiles/cluster-profiles-config.yaml
Comment on lines
+2
to
+84
| - agent: kubernetes | ||
| cluster: build07 | ||
| cron: 0 6 * * 6 | ||
| decorate: true | ||
| decoration_config: | ||
| skip_cloning: true | ||
| extra_refs: | ||
| - base_ref: master | ||
| org: openshift | ||
| repo: hive | ||
| labels: | ||
| ci-operator.openshift.io/cloud: aws | ||
| ci-operator.openshift.io/cloud-cluster-profile: aws-qe | ||
| ci-operator.openshift.io/variant: periodic | ||
| ci.openshift.io/generator: prowgen | ||
| job-release: "4.21" | ||
| pj-rehearse.openshift.io/can-be-rehearsed: "true" | ||
| name: periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa | ||
| spec: | ||
| containers: | ||
| - args: | ||
| - --gcs-upload-secret=/secrets/gcs/service-account.json | ||
| - --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson | ||
| - --lease-server-credentials-file=/etc/boskos/credentials | ||
| - --report-credentials-file=/etc/report/credentials | ||
| - --secret-dir=/secrets/ci-pull-credentials | ||
| - --target=aws-ipi-f7-longduration-hive-sd-rosa | ||
| - --variant=periodic | ||
| command: | ||
| - ci-operator | ||
| env: | ||
| - name: HTTP_SERVER_IP | ||
| valueFrom: | ||
| fieldRef: | ||
| fieldPath: status.podIP | ||
| image: quay-proxy.ci.openshift.org/openshift/ci:ci_ci-operator_latest | ||
| imagePullPolicy: Always | ||
| name: "" | ||
| ports: | ||
| - containerPort: 8080 | ||
| name: http | ||
| resources: | ||
| requests: | ||
| cpu: 10m | ||
| volumeMounts: | ||
| - mountPath: /etc/boskos | ||
| name: boskos | ||
| readOnly: true | ||
| - mountPath: /secrets/ci-pull-credentials | ||
| name: ci-pull-credentials | ||
| readOnly: true | ||
| - mountPath: /secrets/gcs | ||
| name: gcs-credentials | ||
| readOnly: true | ||
| - mountPath: /secrets/manifest-tool | ||
| name: manifest-tool-local-pusher | ||
| readOnly: true | ||
| - mountPath: /etc/pull-secret | ||
| name: pull-secret | ||
| readOnly: true | ||
| - mountPath: /etc/report | ||
| name: result-aggregator | ||
| readOnly: true | ||
| serviceAccountName: ci-operator | ||
| volumes: | ||
| - name: boskos | ||
| secret: | ||
| items: | ||
| - key: credentials | ||
| path: credentials | ||
| secretName: boskos-credentials | ||
| - name: ci-pull-credentials | ||
| secret: | ||
| secretName: ci-pull-credentials | ||
| - name: manifest-tool-local-pusher | ||
| secret: | ||
| secretName: manifest-tool-local-pusher | ||
| - name: pull-secret | ||
| secret: | ||
| secretName: registry-pull-credentials | ||
| - name: result-aggregator | ||
| secret: | ||
| secretName: result-aggregator |
There was a problem hiding this comment.
Add Slack reporter config for this new periodic job.
This job currently has no reporter_config, unlike the other Hive periodics in this file. Without it, failures can go unnoticed.
Suggested patch
- name: periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa
+ name: periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa
+ reporter_config:
+ slack:
+ channel: '#team-hive-alert'
+ job_states_to_report:
+ - failure
+ - error
+ - aborted
+ report_template: Job *{{.Spec.Job}}* ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs>
spec:📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - agent: kubernetes | |
| cluster: build07 | |
| cron: 0 6 * * 6 | |
| decorate: true | |
| decoration_config: | |
| skip_cloning: true | |
| extra_refs: | |
| - base_ref: master | |
| org: openshift | |
| repo: hive | |
| labels: | |
| ci-operator.openshift.io/cloud: aws | |
| ci-operator.openshift.io/cloud-cluster-profile: aws-qe | |
| ci-operator.openshift.io/variant: periodic | |
| ci.openshift.io/generator: prowgen | |
| job-release: "4.21" | |
| pj-rehearse.openshift.io/can-be-rehearsed: "true" | |
| name: periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa | |
| spec: | |
| containers: | |
| - args: | |
| - --gcs-upload-secret=/secrets/gcs/service-account.json | |
| - --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson | |
| - --lease-server-credentials-file=/etc/boskos/credentials | |
| - --report-credentials-file=/etc/report/credentials | |
| - --secret-dir=/secrets/ci-pull-credentials | |
| - --target=aws-ipi-f7-longduration-hive-sd-rosa | |
| - --variant=periodic | |
| command: | |
| - ci-operator | |
| env: | |
| - name: HTTP_SERVER_IP | |
| valueFrom: | |
| fieldRef: | |
| fieldPath: status.podIP | |
| image: quay-proxy.ci.openshift.org/openshift/ci:ci_ci-operator_latest | |
| imagePullPolicy: Always | |
| name: "" | |
| ports: | |
| - containerPort: 8080 | |
| name: http | |
| resources: | |
| requests: | |
| cpu: 10m | |
| volumeMounts: | |
| - mountPath: /etc/boskos | |
| name: boskos | |
| readOnly: true | |
| - mountPath: /secrets/ci-pull-credentials | |
| name: ci-pull-credentials | |
| readOnly: true | |
| - mountPath: /secrets/gcs | |
| name: gcs-credentials | |
| readOnly: true | |
| - mountPath: /secrets/manifest-tool | |
| name: manifest-tool-local-pusher | |
| readOnly: true | |
| - mountPath: /etc/pull-secret | |
| name: pull-secret | |
| readOnly: true | |
| - mountPath: /etc/report | |
| name: result-aggregator | |
| readOnly: true | |
| serviceAccountName: ci-operator | |
| volumes: | |
| - name: boskos | |
| secret: | |
| items: | |
| - key: credentials | |
| path: credentials | |
| secretName: boskos-credentials | |
| - name: ci-pull-credentials | |
| secret: | |
| secretName: ci-pull-credentials | |
| - name: manifest-tool-local-pusher | |
| secret: | |
| secretName: manifest-tool-local-pusher | |
| - name: pull-secret | |
| secret: | |
| secretName: registry-pull-credentials | |
| - name: result-aggregator | |
| secret: | |
| secretName: result-aggregator | |
| - agent: kubernetes | |
| cluster: build07 | |
| cron: 0 6 * * 6 | |
| decorate: true | |
| decoration_config: | |
| skip_cloning: true | |
| extra_refs: | |
| - base_ref: master | |
| org: openshift | |
| repo: hive | |
| labels: | |
| ci-operator.openshift.io/cloud: aws | |
| ci-operator.openshift.io/cloud-cluster-profile: aws-qe | |
| ci-operator.openshift.io/variant: periodic | |
| ci.openshift.io/generator: prowgen | |
| job-release: "4.21" | |
| pj-rehearse.openshift.io/can-be-rehearsed: "true" | |
| name: periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa | |
| reporter_config: | |
| slack: | |
| channel: '#team-hive-alert' | |
| job_states_to_report: | |
| - failure | |
| - error | |
| - aborted | |
| report_template: Job *{{.Spec.Job}}* ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs> | |
| spec: | |
| containers: | |
| - args: | |
| - --gcs-upload-secret=/secrets/gcs/service-account.json | |
| - --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson | |
| - --lease-server-credentials-file=/etc/boskos/credentials | |
| - --report-credentials-file=/etc/report/credentials | |
| - --secret-dir=/secrets/ci-pull-credentials | |
| - --target=aws-ipi-f7-longduration-hive-sd-rosa | |
| - --variant=periodic | |
| command: | |
| - ci-operator | |
| env: | |
| - name: HTTP_SERVER_IP | |
| valueFrom: | |
| fieldRef: | |
| fieldPath: status.podIP | |
| image: quay-proxy.ci.openshift.org/openshift/ci:ci_ci-operator_latest | |
| imagePullPolicy: Always | |
| name: "" | |
| ports: | |
| - containerPort: 8080 | |
| name: http | |
| resources: | |
| requests: | |
| cpu: 10m | |
| volumeMounts: | |
| - mountPath: /etc/boskos | |
| name: boskos | |
| readOnly: true | |
| - mountPath: /secrets/ci-pull-credentials | |
| name: ci-pull-credentials | |
| readOnly: true | |
| - mountPath: /secrets/gcs | |
| name: gcs-credentials | |
| readOnly: true | |
| - mountPath: /secrets/manifest-tool | |
| name: manifest-tool-local-pusher | |
| readOnly: true | |
| - mountPath: /etc/pull-secret | |
| name: pull-secret | |
| readOnly: true | |
| - mountPath: /etc/report | |
| name: result-aggregator | |
| readOnly: true | |
| serviceAccountName: ci-operator | |
| volumes: | |
| - name: boskos | |
| secret: | |
| items: | |
| - key: credentials | |
| path: credentials | |
| secretName: boskos-credentials | |
| - name: ci-pull-credentials | |
| secret: | |
| secretName: ci-pull-credentials | |
| - name: manifest-tool-local-pusher | |
| secret: | |
| secretName: manifest-tool-local-pusher | |
| - name: pull-secret | |
| secret: | |
| secretName: registry-pull-credentials | |
| - name: result-aggregator | |
| secret: | |
| secretName: result-aggregator |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@ci-operator/jobs/openshift/hive/openshift-hive-master-periodics.yaml` around
lines 2 - 84, This job (name:
periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa)
is missing a reporter_config block; add a reporter_config at the job level
mirroring the other Hive periodic jobs so failures are sent to Slack (include
the slack reporter settings: slack channel, cluster/cluster alias labels and the
secret reference for the Slack webhook), ensuring the reporter_config key and
its slack subkeys match the schema used by the other Hive periodics in this
file.
Member
Author
|
/pj-rehearse periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa |
Contributor
|
@miyadav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Member
Author
|
/pj-rehearse periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa |
Contributor
|
@miyadav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
|
@miyadav: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Member
Author
|
/pj-rehearse periodic-ci-openshift-hive-master-periodic-aws-ipi-f7-longduration-hive-sd-rosa |
Contributor
|
@miyadav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/hold
WIP to see if any issues if there is periodic ran from main hive instead of OTP.
Summary by CodeRabbit
Chores
Tests