Skip to content

WIP: OCPBUGS-80958: NodeUID in status to detect replaced node with same name #2821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bhperry wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP: OCPBUGS-80958: NodeUID in status to detect replaced node with same name #2821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions openapi/generated_openapi/zz_generated.openapi.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions openapi/openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46633,6 +46633,10 @@
"type": "string",
"default": ""
},
"nodeUID": {
"description": "nodeUID is the UID of the node. This field is used to detect that a node has been deleted and recreated with the same name. When the UID changes, it indicates the node is a new instance and the status should be reset.",
"type": "string"
},
"targetRevision": {
"description": "targetRevision is the generation of the deployment we're trying to apply. Can not be set on creation of a nodeStatus.",
"type": "integer",
Expand Down
7 changes: 7 additions & 0 deletions operator/v1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package v1
import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/types"
)

// MyOperatorResource is an example operator configuration type
Expand Down Expand Up @@ -266,6 +267,12 @@ type NodeStatus struct {
// +required
NodeName string `json:"nodeName"`

// nodeUID is the UID of the node.
// This field is used to detect that a node has been deleted and recreated with the same name.
// When the UID changes, it indicates the node is a new instance and the status should be reset.
// +optional
NodeUID types.UID `json:"nodeUID,omitempty"`

// currentRevision is the generation of the most recently successful deployment.
// Can not be set on creation of a nodeStatus. Updates must only increase the value.
// +kubebuilder:validation:XValidation:rule="self >= oldSelf",message="must only increase"
Expand Down
6 changes: 6 additions & 0 deletions operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds-CustomNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
6 changes: 6 additions & 0 deletions operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds-Default.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
6 changes: 6 additions & 0 deletions operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds-DevPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
6 changes: 6 additions & 0 deletions operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds-OKD.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
6 changes: 6 additions & 0 deletions operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds-TechPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
6 changes: 6 additions & 0 deletions operator/v1/zz_generated.crd-manifests/0000_20_kube-apiserver_01_kubeapiservers.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
6 changes: 6 additions & 0 deletions ...enerated.crd-manifests/0000_25_kube-controller-manager_01_kubecontrollermanagers.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
6 changes: 6 additions & 0 deletions operator/v1/zz_generated.crd-manifests/0000_25_kube-scheduler_01_kubeschedulers.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
6 changes: 6 additions & 0 deletions ...r/v1/zz_generated.featuregated-crd-manifests/etcds.operator.openshift.io/AAA_ungated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
6 changes: 6 additions & 0 deletions ...zz_generated.featuregated-crd-manifests/etcds.operator.openshift.io/EtcdBackendQuota.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
6 changes: 6 additions & 0 deletions ...enerated.featuregated-crd-manifests/kubeapiservers.operator.openshift.io/AAA_ungated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
6 changes: 6 additions & 0 deletions ...z_generated.featuregated-crd-manifests/kubeapiservers.operator.openshift.io/EventTTL.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
6 changes: 6 additions & 0 deletions ....featuregated-crd-manifests/kubecontrollermanagers.operator.openshift.io/AAA_ungated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
6 changes: 6 additions & 0 deletions ...enerated.featuregated-crd-manifests/kubeschedulers.operator.openshift.io/AAA_ungated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
1 change: 1 addition & 0 deletions operator/v1/zz_generated.swagger_doc_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions payload-manifests/crds/0000_12_etcd_01_etcds-CustomNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
6 changes: 6 additions & 0 deletions payload-manifests/crds/0000_12_etcd_01_etcds-Default.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
6 changes: 6 additions & 0 deletions payload-manifests/crds/0000_12_etcd_01_etcds-DevPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
6 changes: 6 additions & 0 deletions payload-manifests/crds/0000_12_etcd_01_etcds-OKD.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
6 changes: 6 additions & 0 deletions payload-manifests/crds/0000_12_etcd_01_etcds-TechPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
6 changes: 6 additions & 0 deletions payload-manifests/crds/0000_20_kube-apiserver_01_kubeapiservers.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
6 changes: 6 additions & 0 deletions payload-manifests/crds/0000_25_kube-controller-manager_01_kubecontrollermanagers.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down
6 changes: 6 additions & 0 deletions payload-manifests/crds/0000_25_kube-scheduler_01_kubeschedulers.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,12 @@ spec:
nodeName:
description: nodeName is the name of the node
type: string
nodeUID:
description: |-
nodeUID is the UID of the node.
This field is used to detect that a node has been deleted and recreated with the same name.
When the UID changes, it indicates the node is a new instance and the status should be reset.
type: string
targetRevision:
description: |-
targetRevision is the generation of the deployment we're trying to apply.
Expand Down