Spike: convert BNF codelists to dm+d as new-style - #3155
Draft
Jongmassey wants to merge 3 commits into
Draft
Conversation
We are going to need to call this from actions.py so move out of forms into codelist. This is probably a better fit here anyway - it feels more appropriate that a coding system is responsible for deciding whether some csv data is a valid codelist in itself.
We need to call this from actions directly so move out of form into coding system
This changes the behaviour of the `convert_bnf_codelist_version_to_dmd` action to make a new-style dm+d codelist rather than an old-style. This enables the resulting codelist to be edited in the builder, but loses the additional column of the BNF code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re: #3031
Advantages:
Disadvantages: