Fix ChangeMethodInvocationReturnType changing variable type for nested matches

[timtebeek]

What's changed?

ChangeMethodInvocationReturnType rewrote the declared type of a variable whenever a matching method invocation appeared anywhere in the variable declaration subtree — including when the match was nested as an argument to another call, rather than being the initializer itself.

visitVariableDeclarations set a methodUpdated flag from any descendant match and then unconditionally rewrote the declared type. This change additionally requires that one of the variables' initializer is the matched invocation before rewriting the declared type.

What's your motivation?

• Fixes Wrong Cell by CellType logic rewrite-apache#134

The Apache POI 3.17 migration runs:

- org.openrewrite.java.ChangeMethodInvocationReturnType:
    methodPattern: org.apache.poi.ss.usermodel.Cell getCellType()
    newReturnType: org.apache.poi.ss.usermodel.CellType

Against code like:

Cell xlsxCell = xlsxRow.createCell(xlsCell.getColumnIndex(), xlsCell.getCellType());

getCellType() is only an argument to createCell(...), but the recipe rewrote the declaration to CellType xlsxCell = ..., producing uncompilable code (Cell cannot be converted to CellType).

Anything in particular you'd like reviewers to focus on?

The nested method invocation's own return-type attribution is still updated (that is correct); only the enclosing variable's declared type is now left alone when the match isn't the initializer. Added a regression test covering both the legitimate (direct initializer) and the previously-broken (nested argument) cases.

Checklist

• I've added unit tests to cover my changes

[timtebeek]

Note for reviewers: the failing checks are all in :rewrite-csharp:integTest (java.lang.IllegalStateException: RPC process shut down early with exit code 0), affecting even basic tests like parseSimpleProject/xmlDocComment. This is the .NET RPC subprocess failing to start on the CI runner and is unrelated to this change, which only touches ChangeMethodInvocationReturnType in rewrite-java (whose tests pass). Re-running the failed jobs reproduced the identical C# RPC startup failure.

[timtebeek]

Root cause of the red check (confirmed across 3 runs): :rewrite-csharp:integTest fails with IllegalStateException: RPC process shut down early with exit code 0 — the .NET RPC subprocess won't start on the CI runner. This affects even trivial tests (parseSimpleProject, xmlDocComment).

It's pre-existing and unrelated to this change: because this PR modifies rewrite-java (a dependency of rewrite-csharp), it invalidates the Gradle build-cache entry for :rewrite-csharp:integTest, so the task actually executes instead of being served from cache — exposing the broken C# RPC startup. PRs that don't touch rewrite-java get the cached result and stay green; PRs that do (e.g. #7988) hit the same failure. rewrite-java:test (including this change's new tests) passes.

This needs a maintainer to either merge past the known-broken C# integTest or fix the .NET RPC startup in CI.

[MBoegers]

Added a missing path where Cell xlsxCell = (xlsxRow.createCell()) and Cell xlsxCell = someFlag ? xlsxRow.createCell() : null would be missed.

[Pumu3]

Thank you for all @timtebeek. Waiting the mext release for remove custom fix