Repository navigation
Entrypoint changes affecting heap dump storage and OR_JAVA_OPTS - #2868
Conversation
…n on heap dump presence
OR_JAVA_OPTS
OR_JAVA_OPTSOR_JAVA_OPTS
There was a problem hiding this comment.
Pull request overview
This PR updates the manager container startup configuration to persist heap dumps under /storage, retain multiple dumps by renaming them, and standardize JVM option env vars from OR_JAVA_OPTS to JAVA_OPTS + JAVA_OPTS_APPEND.
Changes:
- Update manager/balena entrypoints to rename leftover
/storage/dump.hprofon startup and warn when heap dumps are present. - Change default JVM options in manager/balena Dockerfiles to write heap dumps to
/storage/dump.hprofand run a rename script on OOM. - Replace
OR_JAVA_OPTSwithJAVA_OPTSin test/load profiles and UI test harness.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/test/manager.cjs | Switches UI test harness from OR_JAVA_OPTS to JAVA_OPTS and defines local default JVM args. |
| test/load2-eks/profiles/xlarge/values-manager-eks-load.yaml | Renames env var to JAVA_OPTS for load2 xlarge EKS profile. |
| test/load2-eks/profiles/xlarge-minimal/values-manager-eks-load.yaml | Renames env var to JAVA_OPTS for load2 xlarge-minimal EKS profile. |
| test/load2-eks/profiles/large/values-manager-eks-load.yaml | Renames env var to JAVA_OPTS for load2 large EKS profile. |
| test/load2-eks/profiles/8xlarge/values-manager-eks-load.yaml | Renames env var to JAVA_OPTS for load2 8xlarge EKS profile. |
| test/load2-eks/profiles/4xlarge/values-manager-eks-load.yaml | Renames env var to JAVA_OPTS for load2 4xlarge EKS profile. |
| test/load2-eks/profiles/2xlarge/values-manager-eks-load.yaml | Renames env var to JAVA_OPTS for load2 2xlarge EKS profile. |
| test/load1/deployment1/test-load1.yml | Renames env var to JAVA_OPTS for load1 docker-compose profile. |
| test/load1-eks/values-manager-eks-load.yaml | Renames env var to JAVA_OPTS for load1 EKS values. |
| profile/deploy.yml | Updates documentation comment to reference JAVA_OPTS / JAVA_OPTS_APPEND. |
| manager/heapdump-rename.sh | Adds OOM heap dump rename script for manager image. |
| manager/entrypoint.sh | Adds startup-time heap dump rename + warning, and uses JAVA_OPTS + JAVA_OPTS_APPEND. |
| manager/Dockerfile | Updates default JVM opts (heap dump path + OOM hook) and copies new scripts into image. |
| balena/manager.Dockerfile | Mirrors manager image JVM env changes and switches to entrypoint-based startup. |
| balena/heapdump-rename.sh | Adds OOM heap dump rename script for balena image. |
| balena/entrypoint.sh | Adds startup-time heap dump rename + warning, and uses JAVA_OPTS + JAVA_OPTS_APPEND. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@wborn Can you trigger another review please? |
|
@openremote/core-developers Ready for review |
|
Doc PR also created openremote/documentation#162 |
|
Heap dump references don't need replacing as they relate to ad-hoc heap dump generation |
|



Store heap dumps in /storage dir and add support for multiple and warn on heap dump presence
This allows heap dumps to persist between manager container recreation for analysis purposes.
The entrypoint script also outputs a warning message if heap dumps are found to encourage removal.
Replace
OR_JAVA_OPTSwith more common optionsJAVA_OPTSandJAVA_OPTS_APPEND