Skip to content

Add copyediting shortcuts for editor and author versions#5333

Open
ajrbyers wants to merge 2 commits into
masterfrom
b-3137-copyediting-shortcuts
Open

Add copyediting shortcuts for editor and author versions#5333
ajrbyers wants to merge 2 commits into
masterfrom
b-3137-copyediting-shortcuts

Conversation

@ajrbyers

@ajrbyers ajrbyers commented Jun 5, 2026

Copy link
Copy Markdown
Member

Closes #3137

@StephDriver StephDriver left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Andy, I can't get this to work, unless I cherry-pick 5e275cf from master. So I think when you rebase this on master, all should be well, but as it stands, the css doesn't load.

  2. These tick boxes on the request author version are extremely difficult to see.

Image
  1. Context / Accessibility wise - you have three identically-styled options, one loads a new page (change of context) the other two open small popups that you then can select items without a change of context. This isn't consistent and makes it harder for a user to predict when they will trigger a change of context.

@StephDriver StephDriver assigned ajrbyers and unassigned StephDriver Jun 8, 2026
@ajrbyers ajrbyers force-pushed the b-3137-copyediting-shortcuts branch from f5c74c2 to b54377e Compare June 9, 2026 12:24
@ajrbyers ajrbyers requested a review from StephDriver June 9, 2026 12:25
@ajrbyers ajrbyers assigned StephDriver and unassigned ajrbyers Jun 9, 2026

@StephDriver StephDriver left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Andy, I was still getting tiny tick boxes in safari. A bit of digging later - and none of the new css was in the inspector.

The CSS targets .modal-content form ul li label
but rendered was

Image

<div><label><input>, not <ul><li>.

I suspect Safari default is smaller than other browser defaults.

this worked for me:

  .modal-content form label:has(> input[type="checkbox"]) {
      font-weight: normal;
  }
  
  .modal-content form label > input[type="checkbox"] {
      width: 1rem;
      height: 1rem;
      margin-right: 0.5rem;
      margin-bottom: 0;
      vertical-align: -0.15em;
  }

But - is this me on the wrong version of Django somehow, or wrong settings, or is this real? What do you get in the inspector for these tickboxes?

@StephDriver StephDriver assigned ajrbyers and unassigned StephDriver Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copyediting: Request Author Version/Upload Editor Version

2 participants