Filter article exports by issue and implement pagination#127
Conversation
StephDriver
left a comment
There was a problem hiding this comment.
Andy, I'm a little confused by this PR.
- pagination was better before:
OLD:
New:
-
I like the change of records per page nearer pagination. But previously the records per page options had 5,10,50,25 (yes, not in order!) but now it's 10,25,50,100. Why the loss of 5?
-
The default sort has been lost. Previously this defaulted to sorting by ID. Now there is no default sort. Intentional?
-
The export is in a completely different order of fields within the csv. I did a cell by cell comparison to check all are the same (and they are) but this threw me and I think could throw users if they are used to plugging the export into other processes- is there a reason for reordering it?
-
BUT, the filter by issue is NICE! Especially as collections also show up there.
So I cannot review this as I feel unsure what it was intended to do. There is no linked issue, and no info in the PR conversation.
|
More info:
|
|
@ajrbyers thanks. TLDR: 1 change requested - put the "showing X of Y entries" back into the pagination row. details below.
👍
Ok, that's fine - sounds like it was deliberate, and I certainly approve of having the values in numerical order now.
ok. was comparing to main. And sort order isn't the same.
OK - can the "showing X of Y entries" part that was shown previously be put back? I think that's useful. |
This PR: